This is an archive of the discontinued LLVM Phabricator instance.

Differential D155241

[Fuchsia] Skip building debuginfod if httplib_ROOT is not specified
Needs ReviewPublic

Authored by haowei on Jul 13 2023, 3:44 PM.

Details

Reviewers
phosek
mysterymath
Summary

This patch skipds building debuginfod if httplib_ROOT is not present in the configuration when building Fuchsia Clang toolchain.

I used list(REMOVE_ITEM) instead of list(APPEND) so user can still use -DLLVM_TOOLCHAIN_TOOLS to override the tools to build.

Diff Detail

Event Timeline

haowei created this revision.Jul 13 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2023, 3:44 PM
Herald added a subscriber: abrachet. · View Herald Transcript
haowei requested review of this revision.Jul 13 2023, 3:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2023, 3:44 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B245232: Diff 540197.Jul 13 2023, 8:29 PM

Revision Contents

PathSize
clang/
cmake/
caches/
4 lines

Diff 540197

clang/cmake/caches/Fuchsia-stage2.cmake

Show First 20 Lines • Show All 325 Lines • ▼ Show 20 Linesset(LLVM_TOOLCHAIN_TOOLS
llvm-strip llvm-strip
llvm-symbolizer llvm-symbolizer
llvm-undname llvm-undname
llvm-xray llvm-xray
sancov sancov
scan-build-py scan-build-py
CACHE STRING "") CACHE STRING "")
if (NOT httplib_ROOT)
list(REMOVE_ITEM LLVM_TOOLCHAIN_TOOLS llvm-debuginfod llvm-debuginfod-find)
endif()
set(LLVM_Toolchain_DISTRIBUTION_COMPONENTS set(LLVM_Toolchain_DISTRIBUTION_COMPONENTS
bolt bolt
clang clang
lld lld
clang-apply-replacements clang-apply-replacements
clang-doc clang-doc
clang-format clang-format
clang-resource-headers clang-resource-headers
Show All 26 Lines