[lldb] Move CommandOverrideCallbackWithResult to lldb_private namespace

[bulbazord]

Summary

This has an lldb_private type in its parameter, it should be in
lldb-private-types.h

[JDevlieghere]

LGTM

[mib]

LGTM

lldb/include/lldb/Interpreter/CommandObject.h

public:
   }
 
   void SetOverrideCallback(lldb::CommandOverrideCallback callback,
                            void *baton) {
     m_deprecated_command_override_callback = callback;
     m_command_override_baton = baton;
   }
 
-  void SetOverrideCallback(lldb::CommandOverrideCallbackWithResult callback,
-                           void *baton) {
+  void
+  SetOverrideCallback(lldb_private::CommandOverrideCallbackWithResult callback,
     m_command_override_callback = callback;
     m_command_override_baton = baton;
   }
 
   bool InvokeOverrideCallback(const char **argv, CommandReturnObject &result) {
     if (m_command_override_callback)
       return m_command_override_callback(m_command_override_baton, argv,
                                          result);
protected:
   std::unique_lock<std::recursive_mutex> m_api_locker;
   std::string m_cmd_name;
   std::string m_cmd_help_short;
   std::string m_cmd_help_long;
   std::string m_cmd_syntax;
   Flags m_flags;
   std::vector<CommandArgumentEntry> m_arguments;
   lldb::CommandOverrideCallback m_deprecated_command_override_callback;
-  lldb::CommandOverrideCallbackWithResult m_command_override_callback;
+  lldb_private::CommandOverrideCallbackWithResult m_command_override_callback;
   void *m_command_override_baton;
   bool m_is_user_command = false;
 
   // Helper function to populate IDs or ID ranges as the command argument data
   // to the specified command argument entry.
   static void AddIDsArgumentData(CommandArgumentEntry &arg,
                                  lldb::CommandArgumentType ID,
                                  lldb::CommandArgumentType IDRange);

lldb/include/lldb/lldb-private-types.h

 /// Functor that returns a ValueObjectSP for a variable given its name
 /// and the StackFrame of interest. Used primarily in the Materializer
 /// to refetch a ValueObject when the ExecutionContextScope changes.
 using ValueObjectProviderTy =
     std::function<lldb::ValueObjectSP(ConstString, StackFrame *)>;
 
 typedef void (*DebuggerDestroyCallback)(lldb::user_id_t debugger_id,
                                         void *baton);
+typedef bool (*CommandOverrideCallbackWithResult)(
+    void *baton, const char **argv, lldb_private::CommandReturnObject &result);
 } // namespace lldb_private
 
 #endif // #if defined(__cplusplus)
 
 #endif // LLDB_LLDB_PRIVATE_TYPES_H

lldb/include/lldb/lldb-types.h

 #endif // _WIN32
 
 #define LLDB_INVALID_PROCESS ((lldb::process_t)-1)
 #define LLDB_INVALID_HOST_THREAD ((lldb::thread_t)NULL)
 #define LLDB_INVALID_PIPE ((lldb::pipe_t)-1)
 
 typedef void (*LogOutputCallback)(const char *, void *baton);
 typedef bool (*CommandOverrideCallback)(void *baton, const char **argv);
-typedef bool (*CommandOverrideCallbackWithResult)(
-    void *baton, const char **argv, lldb_private::CommandReturnObject &result);
 typedef bool (*ExpressionCancelCallback)(ExpressionEvaluationPhase phase,
                                          void *baton);
 
 typedef uint64_t addr_t;
 typedef uint64_t user_id_t;
 typedef uint64_t pid_t;
 typedef uint64_t tid_t;
 typedef uint64_t offset_t;