This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Forward arguments of `pair` in `SubElementInterface::replaceImmediateSubElementsImpl`
ClosedPublic

Authored by uenoku on Jul 11 2023, 11:25 PM.

Details

Summary

SubElementInterface::replaceImmediateSubElementsImpl specializes tuples so that
arguments are forwarded to type getter. However currently pairs are not supported even though
an example in documents uses a pair as a key type: https://mlir.llvm.org/docs/DefiningDialects/AttributesAndTypes/#defining-a-storage-class
This patch adds support for pairs as well.

Diff Detail

Event Timeline

uenoku created this revision.Jul 11 2023, 11:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 11 2023, 11:25 PM
uenoku requested review of this revision.Jul 11 2023, 11:25 PM
Mogball accepted this revision.Jul 12 2023, 9:06 AM
This revision is now accepted and ready to land.Jul 12 2023, 9:06 AM
This revision was landed with ongoing or failed builds.Jul 12 2023, 10:07 PM
This revision was automatically updated to reflect the committed changes.