This is an archive of the discontinued LLVM Phabricator instance.

[flang][openacc] Add error for unsupported min/max reduction on complex type
ClosedPublic

Authored by clementval on Jul 11 2023, 2:01 PM.

Details

Summary

reduction operator min and max are not supported with complex type.
Add a proper error so it fails correctly.

Diff Detail

Event Timeline

clementval created this revision.Jul 11 2023, 2:01 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJul 11 2023, 2:01 PM
clementval requested review of this revision.Jul 11 2023, 2:01 PM
razvanlupusoru accepted this revision.Jul 11 2023, 2:26 PM

Looks good. Though it makes me wonder if we should be stricter than just min/max. Other reduction operators including logical don't really apply.

This revision is now accepted and ready to land.Jul 11 2023, 2:26 PM

Looks good. Though it makes me wonder if we should be stricter than just min/max. Other reduction operators including logical don't really apply.

I'll add a semantic check to provide better error message.