This is an archive of the discontinued LLVM Phabricator instance.

[llvm-test-suite][Fortran/gfortran] Categorize compile-only discrepancies in Fortran/gfortran/regression
ClosedPublic

Authored by klausler on Jul 10 2023, 10:35 AM.

Details

Summary

Take a pass through the compilation-only tests in the GNU Fortran regression
test suite that either compile when they shouldn't or don't compile when they
should. Categorize the discrepancies according to root causes for each
test, where it's obvious.

Diff Detail

Repository
rT test-suite

Event Timeline

klausler created this revision.Jul 10 2023, 10:35 AM
Herald added a project: Restricted Project. · View Herald Transcript
klausler requested review of this revision.Jul 10 2023, 10:35 AM
klausler edited projects, added Restricted Project; removed Restricted Project.
klausler edited subscribers, added: flang-commits; removed: Restricted Project.
Herald added a project: Restricted Project. · View Herald TranscriptJul 10 2023, 10:36 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript

Thanks. This is great!

# Unsupported or incomplete extensions that gfortran supports

Are any of the unsupported/incomplete extensions expected to be supported in the future? If not, could they be moved to the UNSUPPORTED_FILES list? That way, we will know not to work on them.

Thanks. This is great!

# Unsupported or incomplete extensions that gfortran supports

Are any of the unsupported/incomplete extensions expected to be supported in the future? If not, could they be moved to the UNSUPPORTED_FILES list? That way, we will know not to work on them.

Yes, if somebody presents a code that uses one of these extensions and asks for support. Otherwise, if there's no need to use them, then there's no need to implement them. The bulk of them can be replaced easily in code with portable standard usage, but some (like Cray pointer edge cases) might still have users. So I can't tell you, definitively.

Yes, if somebody presents a code that uses one of these extensions and asks for support. Otherwise, if there's no need to use them, then there's no need to implement them.

Since they will only be implemented if there is demand, could you move them to the UNSUPPORTED_FILES list? If any are "likely" to be implemented even without an explicit request, they can be left as is.

tblah added a subscriber: tblah.Jul 11 2023, 3:02 AM
klausler updated this revision to Diff 548708.Aug 9 2023, 11:37 AM

Rebase and address comment.

Works fine on AArch64. Please wait for @tarunprabhu.

This revision is now accepted and ready to land.Aug 11 2023, 9:45 AM

Works fine on AArch64. Please wait for @tarunprabhu.

I've pinged him, and will wait a few days for a response.

tarunprabhu accepted this revision.Aug 14 2023, 7:28 AM

Thanks for the changes. LGTM.

This revision was landed with ongoing or failed builds.Aug 14 2023, 8:00 AM
This revision was automatically updated to reflect the committed changes.