This is an archive of the discontinued LLVM Phabricator instance.

[NFC]add initialization for EmitCompactUnwindNonCanonical in ctor
ClosedPublic

Authored by ChengChen002 on Jul 4 2023, 11:04 PM.

Details

Summary

I found that the newly added member variables, "EmitCompactUnwindNonCanonical" were not initialized in the constructor, but other member variables were initialized. The behavior seems to need to be consistent to improve code.

Diff Detail

Event Timeline

ChengChen002 created this revision.Jul 4 2023, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2023, 11:04 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
ChengChen002 requested review of this revision.Jul 4 2023, 11:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 4 2023, 11:04 PM
ChengChen002 retitled this revision from add initializetion for EmitCompactUnwindNonCanonical in ctor to add initialization for EmitCompactUnwindNonCanonical in ctor.Jul 4 2023, 11:39 PM
ChengChen002 edited the summary of this revision. (Show Details)
ChengChen002 added reviewers: int3, oontvoo, thakis, jyknight.
ChengChen002 retitled this revision from add initialization for EmitCompactUnwindNonCanonical in ctor to [NFC]add initialization for EmitCompactUnwindNonCanonical in ctor.Jul 4 2023, 11:45 PM
oontvoo accepted this revision.Jul 7 2023, 10:02 AM

LG - thanks!

This revision is now accepted and ready to land.Jul 7 2023, 10:02 AM

Hi @oontvoo , I don’t have commit access, can you land this patch for me? Thanks.

Sure! Sorry for the delay.