[clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers

[adek05]

Summary

Test for D15443

[Eugene.Zelenko]

Should be moved to Clang-tidy, since clang-modernize is deprecated.

[adek05]

I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy linking everything that clang-modernizer has? If so, I can create another patch which just moves these tests over.

[Eugene.Zelenko]

In D15444#308573, @adek05 wrote:

I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy linking everything that clang-modernizer has? If so, I can create another patch which just moves these tests over.

Clanag-modernize functionality was moved to Clang-tidy and extended there (modernize- check). See http://clang.llvm.org/extra/clang-tidy/checks/list.html.

[adek05]

Moved tests to clang-tidy test suite following Eugene.Zelenko suggestion.

[adek05]

I need a brave soul to review D15443 too, so if you know who else could take a look at it feel free to add people there.

[aaron.ballman]

LGTM, thanks!

[aaron.ballman]

Commit in r257522

test/clang-tidy/modernize-use-override.cpp

struct Base {
   virtual void m2();
   virtual void o() __attribute__((unused));
 
   virtual void r() &;
   virtual void rr() &&;
 
   virtual void cv() const volatile;
   virtual void cv2() const volatile;
+
+  virtual void ne() noexcept(false);
+  virtual void t() throw();
 };
 
 struct SimpleCases : public Base {
 public:
   virtual ~SimpleCases();
   // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-override]
   // CHECK-FIXES: {{^}}  ~SimpleCases() override;
 
public:
 
   virtual void m2() override final;
   // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: 'virtual' and 'override' are redundant since the function is already declared 'final'
   // CHECK-FIXES: {{^}}  void m2() final;
 
   virtual void o() __attribute__((unused));
   // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using
   // CHECK-FIXES: {{^}}  void o() override __attribute__((unused));
+
+  virtual void ne() noexcept(false);
+  // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using
+  // CHECK-FIXES: {{^}}  void ne() noexcept(false) override;
+
+  virtual void t() throw();
+  // CHECK-MESSAGES: :[[@LINE-1]]:16: warning: prefer using
+  // CHECK-FIXES: {{^}}  void t() throw() override;
 };
 
 // CHECK-MESSAGES-NOT: warning:
 
 void SimpleCases::c() {}
 // CHECK-FIXES: {{^}}void SimpleCases::c() {}
 
 SimpleCases::~SimpleCases() {}