Page MenuHomePhabricator

adek05 (Adrian Zgorzałek)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2015, 2:12 AM (268 w, 3 d)

Recent Activity

Jan 19 2016

adek05 updated the diff for D16278: ASTMatcher for ParenExpr node..

@aaron.ballman comments. If it looks good, please commit it for me :)

Jan 19 2016, 9:03 PM

Jan 18 2016

adek05 added inline comments to D16267: Handle C++11 brace initializers in readability-braces-around-statements.
Jan 18 2016, 8:42 PM
adek05 updated the diff for D16286: [clang-tidy] Readability check for redundant parenthesis in return expression..

@LegalizeAdulthood, @Eugene.Zelenko and @omtcyf0 comments

Jan 18 2016, 8:05 PM
adek05 updated subscribers of D16267: Handle C++11 brace initializers in readability-braces-around-statements.
Jan 18 2016, 1:19 PM
adek05 updated subscribers of D16278: ASTMatcher for ParenExpr node..
Jan 18 2016, 1:19 PM
adek05 updated the diff for D16278: ASTMatcher for ParenExpr node..

Update online docs

Jan 18 2016, 10:09 AM
adek05 added inline comments to D16286: [clang-tidy] Readability check for redundant parenthesis in return expression..
Jan 18 2016, 9:30 AM
adek05 updated D16278: ASTMatcher for ParenExpr node..
Jan 18 2016, 9:18 AM
adek05 updated the diff for D16278: ASTMatcher for ParenExpr node..

Fix typo

Jan 18 2016, 9:18 AM
adek05 added a comment to D16278: ASTMatcher for ParenExpr node..

Would you mind committing it for me? I don't have repo access yet.

Jan 18 2016, 9:16 AM

Jan 17 2016

adek05 updated the diff for D16278: ASTMatcher for ParenExpr node..

@klimek comments

Jan 17 2016, 10:23 PM
adek05 updated the diff for D16286: [clang-tidy] Readability check for redundant parenthesis in return expression..

drop -check in the registered name for the checker

Jan 17 2016, 10:19 PM
adek05 retitled D16286: [clang-tidy] Readability check for redundant parenthesis in return expression. from to [clang-tidy] Readability check for redundant parenthesis in return expression..
Jan 17 2016, 10:14 PM
adek05 updated the diff for D16278: ASTMatcher for ParenExpr node..

Fix compilation error

Jan 17 2016, 2:55 PM
adek05 retitled D16278: ASTMatcher for ParenExpr node. from to ASTMatcher for ParenExpr node..
Jan 17 2016, 2:02 PM
adek05 added inline comments to D16267: Handle C++11 brace initializers in readability-braces-around-statements.
Jan 17 2016, 10:39 AM

Jan 16 2016

adek05 retitled D16267: Handle C++11 brace initializers in readability-braces-around-statements from to Handle C++11 brace initializers in readability-braces-around-statements.
Jan 16 2016, 11:03 PM

Jan 12 2016

adek05 added a comment to D15443: Fix getLocEnd for function declarations with exception specification..

Would you mind committing it for me, and I don't have a commit access yet.
Also, could you take a look at D15444 with tests for clang-tidy related to this change?

Jan 12 2016, 12:11 PM

Jan 11 2016

adek05 updated the diff for D15443: Fix getLocEnd for function declarations with exception specification..

Adding testcases in unittest/AST/SourceLocationTest.cpp as suggested by @aaronballman

Jan 11 2016, 8:53 PM

Jan 9 2016

adek05 added a comment to D15443: Fix getLocEnd for function declarations with exception specification..

I think this won't work. If there is a problem with the expression inside throw or noexcept specifier, it will be highlighted inside the parens, never trying to actually access the end location of the function declaration.

Jan 9 2016, 9:57 PM

Dec 18 2015

adek05 added reviewers for D15443: Fix getLocEnd for function declarations with exception specification.: aaron.ballman, jroelofs.

Ping

Dec 18 2015, 1:45 PM

Dec 14 2015

adek05 added inline comments to D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers].
Dec 14 2015, 5:47 PM
adek05 added a comment to D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers].

@aaron.ballman I think this could be hard to achieve without an extra note if you have something like:

Dec 14 2015, 5:38 PM

Dec 13 2015

adek05 updated D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers].
Dec 13 2015, 11:37 PM
adek05 updated D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers].
Dec 13 2015, 11:36 PM
adek05 retitled D15486: [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers] from to [RFC] Emit note pointing to a discarded qualifier [-Wincompatible-pointer-types-discards-qualifiers].
Dec 13 2015, 11:33 PM

Dec 11 2015

adek05 added a comment to D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers.

I need a brave soul to review D15443 too, so if you know who else could take a look at it feel free to add people there.

Dec 11 2015, 1:56 PM
adek05 updated the diff for D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers.

Moved tests to clang-tidy test suite following Eugene.Zelenko suggestion.

Dec 11 2015, 1:52 PM
adek05 added a comment to D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers.

I don't see any tests for AddOverride in tests/clang-tidy yet. Is clang-tidy linking everything that clang-modernizer has? If so, I can create another patch which just moves these tests over.

Dec 11 2015, 12:07 PM
adek05 removed a reviewer for D15443: Fix getLocEnd for function declarations with exception specification.: cfe-commits.
Dec 11 2015, 7:44 AM
adek05 updated subscribers of D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers.
Dec 11 2015, 7:43 AM
adek05 added a reviewer for D15443: Fix getLocEnd for function declarations with exception specification.: cfe-commits.
Dec 11 2015, 7:43 AM
adek05 added a comment to D15443: Fix getLocEnd for function declarations with exception specification..

Tests are in D15444. I do not have a good test plan for this in clang source tree. If you have an idea, let me know.

Dec 11 2015, 12:17 AM
adek05 retitled D15444: [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers from to [clang-modernize] AddOverride: tests for handling throw() and noexcept() specifiers.
Dec 11 2015, 12:16 AM
adek05 retitled D15443: Fix getLocEnd for function declarations with exception specification. from to Fix getLocEnd for function declarations with exception specification..
Dec 11 2015, 12:15 AM