This is an archive of the discontinued LLVM Phabricator instance.

Differential D154405

[profile] Enable loongarch64
ClosedPublic

Authored by Ami-zhang on Jul 3 2023, 7:28 PM.

Details

Reviewers
SixWeining
MaskRay
xen0n
xry111
Commits
rGcea3a8984162: [profile] Enable loongarch64
Summary

Mark loongarch64 as supported for profile. All tests passed.

Diff Detail

Event Timeline

Ami-zhang created this revision.Jul 3 2023, 7:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 7:28 PM
Herald added subscribers: Enna1, s.egerton, simoncook, asb. · View Herald Transcript
Ami-zhang requested review of this revision.Jul 3 2023, 7:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 7:28 PM
Herald added subscribers: Restricted Project, wangpc. · View Herald Transcript
Harbormaster completed remote builds in B242918: Diff 536933.Jul 3 2023, 8:27 PM
SixWeining added a comment.Jul 4 2023, 5:45 AM

People should ensure they have an up-to-date binutils version that supports the R_LARCH_64_PCREL reloc type. This reloc type is used in the __llvm_prf_data section which is generated when instrumentation-based profiling (InstrProfiling) is enabled.

About the summary:

Add support for profile on loongarch64 and pass all tests.

"Add support" generally means some source codes are added. But in this case, we did not add any code. So we can change the sentence to "Mark loongarch64 as supported for profile. All tests passed.".

Ami-zhang added a comment.Jul 4 2023, 6:25 PM

About the summary:

Add support for profile on loongarch64 and pass all tests.

"Add support" generally means some source codes are added. But in this case, we did not add any code. So we can change the sentence to "Mark loongarch64 as supported for profile. All tests passed.".

Ok, I have modified it. Thanks for your suggestion.

Ami-zhang updated this revision to Diff 537193.Jul 4 2023, 6:26 PM
Ami-zhang edited the summary of this revision. (Show Details)

Modify the summary.

Harbormaster completed remote builds in B243106: Diff 537193.Jul 4 2023, 6:48 PM
MaskRay accepted this revision.Jul 5 2023, 11:23 AM
This revision is now accepted and ready to land.Jul 5 2023, 11:23 AM
This revision was landed with ongoing or failed builds.Jul 5 2023, 8:08 PM
Closed by commit rGcea3a8984162: [profile] Enable loongarch64 (authored by Ami-zhang). · Explain Why
This revision was automatically updated to reflect the committed changes.
Ami-zhang added a commit: rGcea3a8984162: [profile] Enable loongarch64.

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 537571

compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines set(ALL_LSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${MIPS64} ${ARM64} ${ARM32}
${PPC64} ${S390X} ${RISCV64} ${HEXAGON} ${LOONGARCH64}) ${PPC64} ${S390X} ${RISCV64} ${HEXAGON} ${LOONGARCH64})
endif() endif()
set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X} set(ALL_MSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X}
${LOONGARCH64}) ${LOONGARCH64})
set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64} ${RISCV64}) set(ALL_HWASAN_SUPPORTED_ARCH ${X86_64} ${ARM64} ${RISCV64})
set(ALL_MEMPROF_SUPPORTED_ARCH ${X86_64}) set(ALL_MEMPROF_SUPPORTED_ARCH ${X86_64})
set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${PPC64} set(ALL_PROFILE_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${PPC32} ${PPC64}
${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON} ${MIPS32} ${MIPS64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}
${RISCV32} ${RISCV64}) ${RISCV32} ${RISCV64} ${LOONGARCH64})
set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X} set(ALL_TSAN_SUPPORTED_ARCH ${X86_64} ${MIPS64} ${ARM64} ${PPC64} ${S390X}
${LOONGARCH64}) ${LOONGARCH64})
set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64} set(ALL_UBSAN_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${RISCV64}
${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON} ${MIPS32} ${MIPS64} ${PPC64} ${S390X} ${SPARC} ${SPARCV9} ${HEXAGON}
${LOONGARCH64}) ${LOONGARCH64})
set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64} set(ALL_SAFESTACK_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${MIPS32} ${MIPS64}
${HEXAGON} ${LOONGARCH64}) ${HEXAGON} ${LOONGARCH64})
set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64} set(ALL_CFI_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${MIPS64}
Show All 18 Lines