This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Add triple for SerenityOS
ClosedPublic

Authored by ADKaster on Jul 3 2023, 6:49 PM.

Diff Detail

Event Timeline

ADKaster created this revision.Jul 3 2023, 6:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 6:49 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
ADKaster requested review of this revision.Jul 3 2023, 6:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 6:49 PM
ADKaster updated this revision to Diff 536935.Jul 3 2023, 7:33 PM

Add unit test

MaskRay accepted this revision.Jul 5 2023, 1:37 PM
MaskRay added a subscriber: MaskRay.
MaskRay added inline comments.
llvm/include/llvm/TargetParser/Triple.h
681

I know you follow some existing comments, but the code really speaks for itself. I think the commend should be removed.

llvm/unittests/TargetParser/TripleTest.cpp
897 ↗(On Diff #536935)

Ensure that this is the triple SerenityOS prefers. I.e. you prefer x86_64-pc-serenity instead of x86_64-unknown-serenity

This revision is now accepted and ready to land.Jul 5 2023, 1:37 PM
ADKaster updated this revision to Diff 557926.Oct 29 2023, 7:48 PM

remove unecessary comment

This revision was automatically updated to reflect the committed changes.