This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Build crtbegin.o/crtend.o for SerenityOS
ClosedPublic

Authored by ADKaster on Jul 3 2023, 6:53 PM.

Diff Detail

Event Timeline

ADKaster created this revision.Jul 3 2023, 6:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 6:53 PM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
ADKaster requested review of this revision.Jul 3 2023, 6:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2023, 6:53 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
ADKaster edited the summary of this revision. (Show Details)Jul 3 2023, 10:50 PM
MaskRay accepted this revision.Jul 5 2023, 1:39 PM
MaskRay added a reviewer: compnerd.
This revision is now accepted and ready to land.Jul 5 2023, 1:39 PM
ADKaster updated this revision to Diff 557928.Oct 29 2023, 7:51 PM
ADKaster edited the summary of this revision. (Show Details)

Also patch builtin-config-ix.cmake

MaskRay accepted this revision.Oct 31 2023, 9:37 AM

This looks good and can land separately. While some projects may want to land everything together, in llvm-project it's not bad to land some patches separately.
As there is a risk that the first patch of series gets reverted due to breakage to some systems and then we may need to revert the dependent patches...
I can land this one for you if you don't have write access to the repository.

I don't personally have write access, but the original author of the patches, @BertalanD does. For all the patches except the profiling one, he should be the commit author. The other patches have Co-Authored-By lines in the Diff description (and on my fork https://github.com/ADKaster/llvm-project/commits/serenityos-upstream) as appropriate from our refinement out-of-tree.

This revision was landed with ongoing or failed builds.Oct 31 2023, 10:47 AM
This revision was automatically updated to reflect the committed changes.