This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement BEQZC and BNEZC instructions
ClosedPublic

Authored by zoran.jovanovic on Dec 10 2015, 6:44 AM.

Diff Detail

Event Timeline

zoran.jovanovic retitled this revision from to [mips][microMIPS] Implement BEQZC and BNEZC instructions.
zoran.jovanovic updated this object.
zoran.jovanovic added a subscriber: llvm-commits.
dsanders requested changes to this revision.Dec 17 2015, 8:58 AM
dsanders edited edge metadata.
dsanders added inline comments.
lib/Target/Mips/Disassembler/MipsDisassembler.cpp
1895–1897

Indentation

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
326–329

Formatting

339

Shouldn't this be filled in? The previous patch (D15526) added the necessary fixup.

Could you also add a test case covering this path?

lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.h
137–138

Indentation

This revision now requires changes to proceed.Dec 17 2015, 8:58 AM
lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
339

This patch is first patch and patch D15526 depends on this one.
D15526 adds necessary fixup and contains corresponding test cases.

zoran.jovanovic edited edge metadata.

New patch version.
Patch rebased and formatting comments addressed.

sdardis accepted this revision.May 11 2016, 5:14 AM
sdardis edited edge metadata.

LGTM.

dsanders accepted this revision.May 17 2016, 3:18 AM
dsanders edited edge metadata.

LGTM. Sorry for the delay.

This revision is now accepted and ready to land.May 17 2016, 3:18 AM
This revision was automatically updated to reflect the committed changes.