[lldb][NFCI] Apply LLDB_DEPRECATED to things that have deprecated comments

[bulbazord]

Summary

Now that we have a proper way to deprecate things in the SB API, we
should apply it where we have manually done so with comments.

[JDevlieghere]

LGTM

lldb/include/lldb/API/SBCommandReturnObject.h

public:
 
   bool IsValid() const;
 
   const char *GetOutput();
 
   const char *GetError();
 
 #ifndef SWIG
-  size_t PutOutput(FILE *fh); // DEPRECATED
+  LLDB_DEPRECATED("Use PutOutput(SBFile) or PutOutput(FileSP)",
+                  "PutOutput(SBFile)")
+  size_t PutOutput(FILE *fh);
 #endif
 
   size_t PutOutput(SBFile file);
 
   size_t PutOutput(FileSP BORROWED);
 
   size_t GetOutputSize();
 
   size_t GetErrorSize();
 
 #ifndef SWIG
-  size_t PutError(FILE *fh); // DEPRECATED
+  LLDB_DEPRECATED("Use PutError(SBFile) or PutError(FileSP)",
+                  "PutError(SBFile)")
+  size_t PutError(FILE *fh);
 #endif
 
   size_t PutError(SBFile file);
 
   size_t PutError(FileSP BORROWED);
 
   void Clear();
 
   lldb::ReturnStatus GetStatus();
 
   void SetStatus(lldb::ReturnStatus status);
 
   bool Succeeded();
 
   bool HasResult();
 
   void AppendMessage(const char *message);
 
   void AppendWarning(const char *message);
 
   bool GetDescription(lldb::SBStream &description);
 
 #ifndef SWIG
-  void SetImmediateOutputFile(FILE *fh); // DEPRECATED
-
-  void SetImmediateErrorFile(FILE *fh); // DEPRECATED
-
-  void SetImmediateOutputFile(FILE *fh, bool transfer_ownership); // DEPRECATED
-
-  void SetImmediateErrorFile(FILE *fh, bool transfer_ownership); // DEPRECATED
+  LLDB_DEPRECATED(
+      "Use SetImmediateOutputFile(SBFile) or SetImmediateOutputFile(FileSP)",
+      "SetImmediateOutputFile(SBFile)")
+  void SetImmediateOutputFile(FILE *fh);
+
+  LLDB_DEPRECATED(
+      "Use SetImmediateErrorFile(SBFile) or SetImmediateErrorFile(FileSP)",
+      "SetImmediateErrorFile(SBFile)")
+  void SetImmediateErrorFile(FILE *fh);
+
+  LLDB_DEPRECATED(
+      "Use SetImmediateOutputFile(SBFile) or SetImmediateOutputFile(FileSP)",
+      "SetImmediateOutputFile(SBFile)")
+  void SetImmediateOutputFile(FILE *fh, bool transfer_ownership);
+
+  LLDB_DEPRECATED(
+      "Use SetImmediateErrorFile(SBFile) or SetImmediateErrorFile(FileSP)",
+      "SetImmediateErrorFile(SBFile)")
+  void SetImmediateErrorFile(FILE *fh, bool transfer_ownership);
 #endif
 
   void SetImmediateOutputFile(SBFile file);
 
   void SetImmediateErrorFile(SBFile file);
 
   void SetImmediateOutputFile(FileSP BORROWED);
 

lldb/include/lldb/API/SBDebugger.h

#endif
   static lldb::SBError InitializeWithErrorHandling();
 
   static void PrintStackTraceOnError();
 
   static void PrintDiagnosticsOnError();
 
   static void Terminate();
 
-  // Deprecated, use the one that takes a source_init_files bool.
+  LLDB_DEPRECATED("Use one of the other Create variants", "Create(bool)")
   static lldb::SBDebugger Create();
 
   static lldb::SBDebugger Create(bool source_init_files);
 
   static lldb::SBDebugger Create(bool source_init_files,
                                  lldb::LogOutputCallback log_callback,
                                  void *baton);
 
#endif
   
   void RequestInterrupt();
   void CancelInterruptRequest();
   bool InterruptRequested();
 
   lldb::SBListener GetListener();
 
 #ifndef SWIG
+  LLDB_DEPRECATED(
+      "Use HandleProcessEvent(const SBProcess &, const SBEvent &, SBFile, "
+      "SBFile) or HandleProcessEvent(const SBProcess &, const SBEvent &, "
+      "FileSP, FileSP)",
+      "HandleProcessEvent(const SBProcess &, const SBEvent &, SBFile, SBFile)")
   void HandleProcessEvent(const lldb::SBProcess &process,
                           const lldb::SBEvent &event, FILE *out,
-                          FILE *err); // DEPRECATED
+                          FILE *err);
 #endif
 
   void HandleProcessEvent(const lldb::SBProcess &process,
                           const lldb::SBEvent &event, SBFile out, SBFile err);
 
 #ifdef SWIG
   void HandleProcessEvent(const lldb::SBProcess &process,
                           const lldb::SBEvent &event, FileSP BORROWED, FileSP BORROWED);
#endif
 
   bool EnableLog(const char *channel, const char **categories);
 
   void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
 
   void SetDestroyCallback(lldb::SBDebuggerDestroyCallback destroy_callback,
                           void *baton);
 
-  // DEPRECATED
 #ifndef SWIG
+  LLDB_DEPRECATED("Use DispatchInput(const void *, size_t)",
+                  "DispatchInput(const void *, size_t)")
   void DispatchInput(void *baton, const void *data, size_t data_len);
 #endif
 
   void DispatchInput(const void *data, size_t data_len);
 
   void DispatchInputInterrupt();
 
   void DispatchInputEndOfFile();

lldb/include/lldb/API/SBFileSpec.h

 namespace lldb {
 
 class LLDB_API SBFileSpec {
 public:
   SBFileSpec();
 
   SBFileSpec(const lldb::SBFileSpec &rhs);
 
-  SBFileSpec(const char *path); // Deprecated, use SBFileSpec (const char *path,
-                                // bool resolve)
+  LLDB_DEPRECATED("Use the other constructor to determine if this the file "
+                  "spec should be resolved",
+                  "SBFileSpec(const char *, bool)")
+  SBFileSpec(const char *path);
 
   SBFileSpec(const char *path, bool resolve);
 
   ~SBFileSpec();
 
   const SBFileSpec &operator=(const lldb::SBFileSpec &rhs);
 
   explicit operator bool() const;

lldb/include/lldb/API/SBProcess.h

public:
   const lldb::SBProcess &operator=(const lldb::SBProcess &rhs);
 
   ~SBProcess();
 
   static const char *GetBroadcasterClassName();
 
   const char *GetPluginName();
 
-  // DEPRECATED: use GetPluginName()
+  LLDB_DEPRECATED("Use GetPluginName()", "GetPluginName()")
   const char *GetShortPluginName();
 
   void Clear();
 
   explicit operator bool() const;
 
   bool IsValid() const;
 

lldb/include/lldb/API/SBValue.h

public:
   bool IsSynthetic();
 
   bool IsSyntheticChildrenGenerated();
 
   void SetSyntheticChildrenGenerated(bool);
 
   const char *GetLocation();
 
-  // Deprecated - use the one that takes SBError&
+  LLDB_DEPRECATED("Use the variant that takes an SBError &",
+                  "SetValueFromCString(const char *, SBError &)")
   bool SetValueFromCString(const char *value_str);
 
   bool SetValueFromCString(const char *value_str, lldb::SBError &error);
 
   lldb::SBTypeFormat GetTypeFormat();
 
   lldb::SBTypeSummary GetTypeSummary();
 
   lldb::SBTypeFilter GetTypeFilter();
 
   lldb::SBTypeSynthetic GetTypeSynthetic();
 
   lldb::SBValue GetChildAtIndex(uint32_t idx);
 
   lldb::SBValue CreateChildAtOffset(const char *name, uint32_t offset,
                                     lldb::SBType type);
 
-  // Deprecated - use the expression evaluator to perform type casting
+  LLDB_DEPRECATED("Use the expression evaluator to perform type casting", "")
   lldb::SBValue Cast(lldb::SBType type);
 
   lldb::SBValue CreateValueFromExpression(const char *name,
                                           const char *expression);
 
   lldb::SBValue CreateValueFromExpression(const char *name,
                                           const char *expression,
                                           SBExpressionOptions &options);
public:
   lldb::SBProcess GetProcess();
 
   lldb::SBThread GetThread();
 
   lldb::SBFrame GetFrame();
 
   lldb::SBValue Dereference();
 
-  // Deprecated - please use GetType().IsPointerType() instead.
+  LLDB_DEPRECATED("Use GetType().IsPointerType() instead", "")
   bool TypeIsPointerType();
 
   lldb::SBType GetType();
 
   lldb::SBValue Persist();
 
   bool GetDescription(lldb::SBStream &description);