This is an archive of the discontinued LLVM Phabricator instance.

Differential D153736

[mlir][index] Add `index.mul` identity folders
ClosedPublic

Authored by Mogball on Jun 25 2023, 6:19 PM.

Details

Reviewers
rriddle
nicolasvasilache
Commits
rG42092c071a84: [mlir][index] Add `index.mul` identity folders
Summary

Fold mul(x, 1) and mul(x, 0).

Depends on D153736

Diff Detail

Event Timeline

Mogball created this revision.Jun 25 2023, 6:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2023, 6:19 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
Mogball requested review of this revision.Jun 25 2023, 6:19 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptJun 25 2023, 6:19 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B241071: Diff 534398.Jun 25 2023, 6:20 PM
Mogball updated this revision to Diff 534399.Jun 25 2023, 6:24 PM

update stack

Mogball edited the summary of this revision. (Show Details)Jun 25 2023, 6:24 PM
Harbormaster completed remote builds in B241072: Diff 534399.Jun 25 2023, 6:25 PM
Mogball edited parent revisions, added: D153732: [mlir][index] Fold `cmp(max/min(x, cstA), cstB)`; removed: D153731: [mlir][index] Mark certain ops as Commutative.Jun 25 2023, 6:25 PM
Mogball updated this revision to Diff 534400.Jun 25 2023, 6:25 PM

kick CI

Harbormaster completed remote builds in B241073: Diff 534400.Jun 25 2023, 6:36 PM
Mogball added a child revision: D153780: [mlir][index] Add identity folders for add and sub.Jun 26 2023, 8:29 AM
rriddle accepted this revision.Jun 26 2023, 11:47 AM
rriddle added inline comments.
mlir/lib/Dialect/Index/IR/IndexOps.cpp
145–161

I would assume this would just work (given it's just a PointerUnion internally, which defines an operator bool)

This revision is now accepted and ready to land.Jun 26 2023, 11:47 AM
Closed by commit rG42092c071a84: [mlir][index] Add `index.mul` identity folders (authored by Mogball). · Explain WhyJun 26 2023, 11:49 AM
This revision was automatically updated to reflect the committed changes.
Mogball added a commit: rG42092c071a84: [mlir][index] Add `index.mul` identity folders.
Mogball added inline comments.Jun 26 2023, 11:54 AM
mlir/lib/Dialect/Index/IR/IndexOps.cpp
145–161

Yep. I fixed it in the next patch

Revision Contents

PathSize
mlir/
lib/
Dialect/
Index/
IR/
19 lines
test/
Dialect/
Index/
10 lines

Diff 534679

mlir/lib/Dialect/Index/IR/IndexOps.cpp

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Lines return foldBinaryOpUnchecked(
[](const APInt &lhs, const APInt &rhs) { return lhs - rhs; }); [](const APInt &lhs, const APInt &rhs) { return lhs - rhs; });
} }
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// MulOp // MulOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
OpFoldResult MulOp::fold(FoldAdaptor adaptor) { OpFoldResult MulOp::fold(FoldAdaptor adaptor) {
return foldBinaryOpUnchecked( if (OpFoldResult result = foldBinaryOpUnchecked(
adaptor.getOperands(), adaptor.getOperands(),
[](const APInt &lhs, const APInt &rhs) { return lhs * rhs; }); [](const APInt &lhs, const APInt &rhs) { return lhs * rhs; });
!result.isNull())
return result;
if (auto rhs = dyn_cast_or_null<IntegerAttr>(adaptor.getRhs())) {
// Fold `mul(x, 1) -> x`.
if (rhs.getValue().isOne())
return getLhs();
// Fold `mul(x, 0) -> 0`.
if (rhs.getValue().isZero())
return rhs;
}
return {};
} }
rriddleUnsubmitted
Not Done
ReplyInline Actions
OpFoldResult MulOp::fold(FoldAdaptor adaptor) {
if (OpFoldResult result = foldBinaryOpUnchecked(
adaptor.getOperands(),
- [](const APInt &lhs, const APInt &rhs) { return lhs * rhs; });
- !result.isNull())
+ [](const APInt &lhs, const APInt &rhs) { return lhs * rhs; }))
return result;
if (auto rhs = dyn_cast_or_null<IntegerAttr>(adaptor.getRhs())) {

I would assume this would just work (given it's just a PointerUnion internally, which defines an operator bool)

rriddle: I would assume this would just work (given it's just a PointerUnion internally, which defines…
MogballAuthorUnsubmitted
Done
ReplyInline Actions

Yep. I fixed it in the next patch

Mogball: Yep. I fixed it in the next patch
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// DivSOp // DivSOp
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
OpFoldResult DivSOp::fold(FoldAdaptor adaptor) { OpFoldResult DivSOp::fold(FoldAdaptor adaptor) {
return foldBinaryOpChecked( return foldBinaryOpChecked(
adaptor.getOperands(), adaptor.getOperands(),
▲ Show 20 Lines • Show All 402 Lines • Show Last 20 Lines

mlir/test/Dialect/Index/index-canonicalize.mlir

Show First 20 Lines • Show All 515 Lines • ▼ Show 20 Linesfunc.func @cmp_maxs(%arg0: index) -> (i1, i1) {
%idx0 = index.constant 0 %idx0 = index.constant 0
%idx1 = index.constant 1 %idx1 = index.constant 1
%0 = index.maxs %arg0, %idx1 %0 = index.maxs %arg0, %idx1
%1 = index.cmp sgt(%0, %idx0) %1 = index.cmp sgt(%0, %idx0)
%2 = index.cmp eq(%0, %idx0) %2 = index.cmp eq(%0, %idx0)
// CHECK: return %true, %false // CHECK: return %true, %false
return %1, %2 : i1, i1 return %1, %2 : i1, i1
} }
// CHECK-LABEL: @mul_identity
func.func @mul_identity(%arg0: index) -> (index, index) {
%idx0 = index.constant 0
%idx1 = index.constant 1
%0 = index.mul %arg0, %idx0
%1 = index.mul %arg0, %idx1
// CHECK: return %idx0, %arg0
return %0, %1 : index, index
}