[clang][Interp] Fix return statements with expresssion in void functions

[tbaeder]

Summary

If the return type of a function is void, ReturnType is not set, but we
used to emit a RVOPtr instruction, which doesn't make sense for a
function returning void.

[shafik]

clang/lib/AST/Interp/ByteCodeStmtGen.cpp

312

You could also guard the cleanup and emitRet above w/ this check, so as to avoid code repetition.

clang/lib/AST/Interp/ByteCodeStmtGen.cpp

bool ByteCodeStmtGen<Emitter>::visitReturnStmt(const ReturnStmt *RS) {
   if (const Expr *RE = RS->getRetValue()) {
     ExprScope<Emitter> RetScope(this);
     if (ReturnType) {
       // Primitive types are simply returned.
       if (!this->visit(RE))
         return false;
       this->emitCleanup();
       return this->emitRet(*ReturnType, RS);
+    } else if (RE->getType()->isVoidType()) {
+      if (!this->visit(RE))
+        return false;
     } else {
       // RVO - construct the value in the return location.
       if (!this->emitRVOPtr(RE))
         return false;
       if (!this->visitInitializer(RE))
         return false;
       if (!this->emitPopPtr(RE))
         return false;

clang/test/AST/Interp/functions.cpp

constexpr const int &p2() {
     return a; // ref-warning {{reference to stack memory associated with local variable}} \
               // expected-warning {{reference to stack memory associated with local variable}}
   }
 
   static_assert(p2() == 12, ""); // ref-error {{not an integral constant expression}} \
                                  // ref-note {{read of variable whose lifetime has ended}} \
                                  // expected-error {{not an integral constant expression}}
 }
+
+namespace VoidReturn {
+  /// ReturnStmt with an expression in a void function used to cause problems.
+  constexpr void bar() {}
+  constexpr void foo() {
+    return bar();
+  }
+  static_assert((foo(),1) == 1, "");
+}