[lit] Remove dead code not referenced, documented or tested anywhere

[ldionne]

Gentle ping here, this should be an easy one.

[yln]

Do we need to worry about out-of-tree users?

[ldionne]

In D153534#4461054, @yln wrote:

Do we need to worry about out-of-tree users?

We might, but do we have a way to know about those? At the very least this isn't tested and there's a bunch of TODOs in it, so it seems like it's not something we're super proud of.

Personally, I would remove it and then ask for forgiveness if we break some people (and then I'd probably suggest that these folks should maintain their own copy of this class instead of Lit providing it, unless there's many users that are broken).

[ldionne]

I'll go ahead and ship this. If someone notices problems, please ping this review (or even better, ping me on the #libcxx Discord channel if you want to make sure this isn't missed). We'll figure out the path forward in case some out-of-tree folks were relying on this (which I think is unlikely).

llvm/utils/lit/lit/formats/__init__.py

 from lit.formats.base import (  # noqa: F401
     TestFormat,
     FileBasedTest,
-    OneCommandPerFileTest,
     ExecutableTest,
 )
 
 from lit.formats.googletest import GoogleTest  # noqa: F401
 from lit.formats.shtest import ShTest  # noqa: F401

llvm/utils/lit/lit/formats/base.py

def getTestsInDirectory(self, testSuite, path_in_suite, litConfig, localConfig):
             filepath = os.path.join(source_path, filename)
             if not os.path.isdir(filepath):
                 for t in self.getTestsForPath(testSuite, path_in_suite + (filename,), litConfig, localConfig):
                     yield t
 
 
 ###
 
-import re
-import tempfile
-
-
-class OneCommandPerFileTest(TestFormat):
-    # FIXME: Refactor into generic test for running some command on a directory
-    # of inputs.
-
-    def __init__(self, command, dir, recursive=False, pattern=".*", useTempInput=False):
-        if isinstance(command, str):
-            self.command = [command]
-        else:
-            self.command = list(command)
-        if dir is not None:
-            dir = str(dir)
-        self.dir = dir
-        self.recursive = bool(recursive)
-        self.pattern = re.compile(pattern)
-        self.useTempInput = useTempInput
-
-    def getTestsInDirectory(self, testSuite, path_in_suite, litConfig, localConfig):
-        dir = self.dir
-        if dir is None:
-            dir = testSuite.getSourcePath(path_in_suite)
-
-        for dirname, subdirs, filenames in os.walk(dir):
-            if not self.recursive:
-                subdirs[:] = []
-
-            subdirs[:] = [
-                d for d in subdirs if (d != ".svn" and d not in localConfig.excludes)
-            ]
-
-            for filename in filenames:
-                if (
-                    filename.startswith(".")
-                    or not self.pattern.match(filename)
-                    or filename in localConfig.excludes
-                ):
-                    continue
-
-                path = os.path.join(dirname, filename)
-                suffix = path[len(dir) :]
-                if suffix.startswith(os.sep):
-                    suffix = suffix[1:]
-                test = lit.Test.Test(
-                    testSuite, path_in_suite + tuple(suffix.split(os.sep)), localConfig
-                )
-                # FIXME: Hack?
-                test.source_path = path
-                yield test
-
-    def createTempInput(self, tmp, test):
-        raise NotImplementedError("This is an abstract method.")
-
-    def execute(self, test, litConfig):
-        if test.config.unsupported:
-            return (lit.Test.UNSUPPORTED, "Test is unsupported")
-
-        cmd = list(self.command)
-
-        # If using temp input, create a temporary file and hand it to the
-        # subclass.
-        if self.useTempInput:
-            tmp = tempfile.NamedTemporaryFile(suffix=".cpp")
-            self.createTempInput(tmp, test)
-            tmp.flush()
-            cmd.append(tmp.name)
-        elif hasattr(test, "source_path"):
-            cmd.append(test.source_path)
-        else:
-            cmd.append(test.getSourcePath())
-
-        out, err, exitCode = lit.util.executeCommand(cmd)
-
-        diags = out + err
-        if not exitCode and not diags.strip():
-            return lit.Test.PASS, ""
-
-        # Try to include some useful information.
-        report = """Command: %s\n""" % " ".join(["'%s'" % a for a in cmd])
-        if self.useTempInput:
-            report += """Temporary File: %s\n""" % tmp.name
-            report += "--\n%s--\n" "" % open(tmp.name).read()
-        report += """Output:\n--\n%s--""" % diags
-
-        return lit.Test.FAIL, report
-
-
-###
-
 # Check exit code of a simple executable with no input
 class ExecutableTest(FileBasedTest):
     def execute(self, test, litConfig):
         if test.config.unsupported:
             return lit.Test.UNSUPPORTED
 
         out, err, exitCode = lit.util.executeCommand(test.getSourcePath())
 
         if not exitCode:
             return lit.Test.PASS, ""
 
         return lit.Test.FAIL, out + err