[llvm-profgen] Remove target triple check to allow for more targets

[hoy]

Summary

Llvm-profgen internally uses the llvm libraries and the MCDesc interface to do disassembling and symblization and it never checks against target-specific instruction operators. This makes it quite transparent to targets and a first attempt for an aarch64 binary just works. Therefore I'm removing the unnecessary triple check to unblock for new targets.

[wenlei]

it rarely checks against target-specific instruction operators

Rarely indicates it's still doing it somewhere? What are those places and are we confident about non-X86 targets?

[hoy]

In D153449#4442757, @wenlei wrote:

it rarely checks against target-specific instruction operators

Rarely indicates it's still doing it somewhere? What are those places and are we confident about non-X86 targets?

Actually I haven't seen any so far.

[wenlei]

In D153449#4442880, @hoy wrote:

In D153449#4442757, @wenlei wrote:

it rarely checks against target-specific instruction operators

Rarely indicates it's still doing it somewhere? What are those places and are we confident about non-X86 targets?

Actually I haven't seen any so far.

Ok, update the description then?

[hoy]

In D153449#4444530, @wenlei wrote:

In D153449#4442880, @hoy wrote:

In D153449#4442757, @wenlei wrote:

it rarely checks against target-specific instruction operators

Rarely indicates it's still doing it somewhere? What are those places and are we confident about non-X86 targets?

Actually I haven't seen any so far.

Ok, update the description then?

Yeah, updated to "never".

llvm/tools/llvm-profgen/ProfiledBinary.cpp

void ProfiledBinary::load() {
   OwningBinary<Binary> OBinary = unwrapOrError(createBinary(Path), Path);
   Binary &ExeBinary = *OBinary.getBinary();
 
   auto *Obj = dyn_cast<ELFObjectFileBase>(&ExeBinary);
   if (!Obj)
     exitWithError("not a valid Elf image", Path);
 
   TheTriple = Obj->makeTriple();
-  // Current only support X86
-  if (!TheTriple.isX86())
-    exitWithError("unsupported target", TheTriple.getTriple());
+
   LLVM_DEBUG(dbgs() << "Loading " << Path << "\n");
 
   // Find the preferred load address for text sections.
   setPreferredTextSegmentAddresses(Obj);
 
   // Load debug info of subprograms from DWARF section.
   // If path of debug info binary is specified, use the debug info from it,
   // otherwise use the debug info from the executable binary.