This is an archive of the discontinued LLVM Phabricator instance.

Differential D153265

[mlir] mark libraries in mlir/examples as such
ClosedPublic

Authored by ftynse on Jun 19 2023, 4:23 AM.

Details

Reviewers
mehdi_amini
Commits
rGe2b19ef6ac7e: [mlir] mark libraries in mlir/examples as such
Summary

LLVM build system separates between add_llvm_example_library and
add_llvm_library, which is presumably used to package examples
separately from the regular library. Introduce a similar approach to
building example libraries in MLIR and use it for the transform dialect
tutorial.

Diff Detail

Event Timeline

ftynse created this revision.Jun 19 2023, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 4:23 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
ftynse requested review of this revision.Jun 19 2023, 4:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 19 2023, 4:23 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B239772: Diff 532603.Jun 19 2023, 4:44 AM
mehdi_amini accepted this revision.Jun 19 2023, 5:04 AM
This revision is now accepted and ready to land.Jun 19 2023, 5:04 AM
ftynse updated this revision to Diff 532692.Jun 19 2023, 9:15 AM

Introduce add_mlir_example_library

We cannot use LLVM's one directly because it will include the library into
LLVM installation.

ftynse edited the summary of this revision. (Show Details)Jun 19 2023, 9:16 AM
Harbormaster completed remote builds in B239834: Diff 532692.Jun 19 2023, 9:43 AM
Closed by commit rGe2b19ef6ac7e: [mlir] mark libraries in mlir/examples as such (authored by ftynse). · Explain WhyJun 20 2023, 4:02 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rGe2b19ef6ac7e: [mlir] mark libraries in mlir/examples as such.

Revision Contents

PathSize
mlir/
examples/
transform/
Ch2/
lib/
7 lines
Ch3/
lib/
7 lines

Diff 532603

mlir/examples/transform/Ch2/lib/CMakeLists.txt

add_mlir_library( # Outside examples, this should be `add_mlir_library`.
add_llvm_example_library(
# Library called MyExtension. # Library called MyExtension.
MyExtensionCh2 MyExtensionCh2
# Built from the following source files. # Built from the following source files.
MyExtension.cpp MyExtension.cpp
# Do not make this part of the main library distribution.
# Needed for the example only.
EXCLUDE_FROM_LIBMLIR
# Make includes visible without top-level path. # Make includes visible without top-level path.
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${PROJECT_SOURCE_DIR}/examples/transform/Ch2/include ${PROJECT_SOURCE_DIR}/examples/transform/Ch2/include
# Make sure ODS declaration and definitions are generated before compiling this. # Make sure ODS declaration and definitions are generated before compiling this.
DEPENDS DEPENDS
MyExtensionCh2IncGen MyExtensionCh2IncGen
# Link in the transform dialect, an all generated dialects. # Link in the transform dialect, an all generated dialects.
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRTransformDialect MLIRTransformDialect
MLIRFuncDialect MLIRFuncDialect
MLIRSCFDialect MLIRSCFDialect
) )

mlir/examples/transform/Ch3/lib/CMakeLists.txt

add_mlir_library( # Outside examples, this should be `add_mlir_library`.
add_llvm_example_library(
# Library called MyExtension. # Library called MyExtension.
MyExtensionCh3 MyExtensionCh3
# Built from the following source files. # Built from the following source files.
MyExtension.cpp MyExtension.cpp
# Do not make this part of the main library distribution.
# Needed for the example only.
EXCLUDE_FROM_LIBMLIR
# Make includes visible without top-level path. # Make includes visible without top-level path.
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${PROJECT_SOURCE_DIR}/examples/transform/Ch3/include ${PROJECT_SOURCE_DIR}/examples/transform/Ch3/include
# Make sure ODS declaration and definitions are generated before compiling this. # Make sure ODS declaration and definitions are generated before compiling this.
DEPENDS DEPENDS
MyExtensionCh3IncGen MyExtensionCh3IncGen
# Link in the transform dialect, an all generated dialects. # Link in the transform dialect, an all generated dialects.
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRTransformDialect MLIRTransformDialect
MLIRFuncDialect MLIRFuncDialect
MLIRSCFDialect MLIRSCFDialect
) )