This is an archive of the discontinued LLVM Phabricator instance.

[libc] Disable atomic optimizations for `libc` AMDGPU builds
ClosedPublic

Authored by jhuber6 on Jun 18 2023, 3:50 PM.

Details

Summary

Recently the AMDGPU backend automatically enables a pass to optimize
atomics. This results in the LTO build taking about 10x longer in all
cases. For now we disable this by default as was the case before the
patch in D152649.

Diff Detail

Event Timeline

jhuber6 created this revision.Jun 18 2023, 3:50 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJun 18 2023, 3:50 PM
jhuber6 requested review of this revision.Jun 18 2023, 3:50 PM
lntue accepted this revision.Jun 18 2023, 10:13 PM
This revision is now accepted and ready to land.Jun 18 2023, 10:13 PM

The D153261 should be fixing the issue. Also, We need to reverse this changes since the command line option amdgpu-atomic-optimizations will be removed completely through D153007. Now, -amdgpu-atomic-optimizer-strategy=None disables the atomic optimizer pass.

The D153261 should be fixing the issue. Also, We need to reverse this changes since the command line option amdgpu-atomic-optimizations will be removed completely through D153007. Now, -amdgpu-atomic-optimizer-strategy=None disables the atomic optimizer pass.

Thanks for the fix, I've removed this upstream.