This is an archive of the discontinued LLVM Phabricator instance.

Differential D153166

AMDGPU: Remove add_dependencies calls from CMakeLists.txt
ClosedPublic

Authored by tstellar on Jun 16 2023, 1:05 PM.

Details

Reviewers
arsenm
Commits
rG62748e934c74: AMDGPU: Remove add_dependencies calls from CMakeLists.txt
Summary

These are redundant. The same dependencies are being added as part
of the add_llvm_component_library() call. I confirmed this by diff'ing
the build.ninja files before and after the change and saw no change.

Diff Detail

Unit TestsFailed

TimeTest
60,060 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp

Event Timeline

tstellar created this revision.Jun 16 2023, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 1:05 PM
Herald added subscribers: foad, kerbowa, hiraditya and 5 others. · View Herald Transcript
tstellar requested review of this revision.Jun 16 2023, 1:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 16 2023, 1:05 PM
Herald added a subscriber: wdng. · View Herald Transcript
Harbormaster completed remote builds in B239513: Diff 532275.Jun 16 2023, 2:30 PM
arsenm accepted this revision.Jun 16 2023, 3:16 PM
This revision is now accepted and ready to land.Jun 16 2023, 3:16 PM
This revision was landed with ongoing or failed builds.Jul 5 2023, 8:03 PM
Closed by commit rG62748e934c74: AMDGPU: Remove add_dependencies calls from CMakeLists.txt (authored by tstellar). · Explain Why
This revision was automatically updated to reflect the committed changes.
tstellar added a commit: rG62748e934c74: AMDGPU: Remove add_dependencies calls from CMakeLists.txt.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
AsmParser/
2 lines
Disassembler/
2 lines
MCA/
2 lines
MCTargetDesc/
2 lines

Diff 532275

llvm/lib/Target/AMDGPU/AsmParser/CMakeLists.txt

add_llvm_component_library(LLVMAMDGPUAsmParser add_llvm_component_library(LLVMAMDGPUAsmParser
AMDGPUAsmParser.cpp AMDGPUAsmParser.cpp
LINK_COMPONENTS LINK_COMPONENTS
AMDGPUDesc AMDGPUDesc
AMDGPUInfo AMDGPUInfo
AMDGPUUtils AMDGPUUtils
CodeGenTypes CodeGenTypes
MC MC
MCParser MCParser
Support Support
TargetParser TargetParser
ADD_TO_COMPONENT ADD_TO_COMPONENT
AMDGPU AMDGPU
) )
add_dependencies(LLVMAMDGPUAsmParser LLVMAMDGPUUtils)

llvm/lib/Target/AMDGPU/Disassembler/CMakeLists.txt

Show All 9 Linesadd_llvm_component_library(LLVMAMDGPUDisassembler
CodeGenTypes CodeGenTypes
MC MC
MCDisassembler MCDisassembler
Support Support
ADD_TO_COMPONENT ADD_TO_COMPONENT
AMDGPU AMDGPU
) )
add_dependencies(LLVMAMDGPUDisassembler AMDGPUCommonTableGen LLVMAMDGPUUtils)

llvm/lib/Target/AMDGPU/MCA/CMakeLists.txt

Show All 9 Linesadd_llvm_component_library(LLVMAMDGPUTargetMCA
MCA MCA
MCParser MCParser
Support Support
TargetParser TargetParser
ADD_TO_COMPONENT ADD_TO_COMPONENT
AMDGPU AMDGPU
) )
add_dependencies(LLVMAMDGPUTargetMCA LLVMAMDGPUUtils)

llvm/lib/Target/AMDGPU/MCTargetDesc/CMakeLists.txt

Show All 19 Linesadd_llvm_component_library(LLVMAMDGPUDesc
Core Core
MC MC
Support Support
TargetParser TargetParser
ADD_TO_COMPONENT ADD_TO_COMPONENT
AMDGPU AMDGPU
) )
add_dependencies(LLVMAMDGPUDesc LLVMAMDGPUUtils)