This is an archive of the discontinued LLVM Phabricator instance.

[mlir] don't install tutorial libraries
ClosedPublic

Authored by ftynse on Jun 15 2023, 10:55 AM.

Diff Detail

Event Timeline

ftynse created this revision.Jun 15 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 10:55 AM
ftynse requested review of this revision.Jun 15 2023, 10:55 AM

The DISABLE_INSTALL keyword isn't used in MLIR apparently, how are other libraries handled? For example I see a bunch of add_mlir_library in mlir/test/...

(also if you can add Fix #... in the description to link this to the GitHub issue)

ftynse updated this revision to Diff 532158.Jun 16 2023, 8:12 AM

The test libraries seem to be getting away with just EXCLUDE_FROM_MLIR. Let's try that.

(also if you can add Fix #... in the description to link this to the GitHub issue)

I'm not sure it actually fixes that problem. The packaging scripts seem to only fetching a committed version and at this point it will be faster to wait for the next nightly than to try modifying the scripts for me.

mehdi_amini accepted this revision.Jun 16 2023, 9:27 AM
This revision is now accepted and ready to land.Jun 16 2023, 9:27 AM
This revision was automatically updated to reflect the committed changes.