This is an archive of the discontinued LLVM Phabricator instance.

Differential D153055

[mlir] don't install tutorial libraries
ClosedPublic

Authored by ftynse on Jun 15 2023, 10:55 AM.

Details

Reviewers
mehdi_amini
Commits
rGf17b137f778d: [mlir] don't install tutorial libraries

Diff Detail

Event Timeline

ftynse created this revision.Jun 15 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 10:55 AM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
ftynse requested review of this revision.Jun 15 2023, 10:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 15 2023, 10:55 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added a comment.Jun 15 2023, 12:01 PM

The DISABLE_INSTALL keyword isn't used in MLIR apparently, how are other libraries handled? For example I see a bunch of add_mlir_library in mlir/test/...

mehdi_amini added a comment.Jun 15 2023, 12:01 PM

(also if you can add Fix #... in the description to link this to the GitHub issue)

Harbormaster completed remote builds in B239184: Diff 531833.Jun 15 2023, 12:21 PM
ftynse updated this revision to Diff 532158.Jun 16 2023, 8:12 AM

The test libraries seem to be getting away with just EXCLUDE_FROM_MLIR. Let's try that.

ftynse added a comment.Jun 16 2023, 8:13 AM

(also if you can add Fix #... in the description to link this to the GitHub issue)

I'm not sure it actually fixes that problem. The packaging scripts seem to only fetching a committed version and at this point it will be faster to wait for the next nightly than to try modifying the scripts for me.

Harbormaster completed remote builds in B239427: Diff 532158.Jun 16 2023, 8:34 AM
mehdi_amini accepted this revision.Jun 16 2023, 9:27 AM
This revision is now accepted and ready to land.Jun 16 2023, 9:27 AM
Closed by commit rGf17b137f778d: [mlir] don't install tutorial libraries (authored by ftynse). · Explain WhyJun 16 2023, 9:32 AM
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rGf17b137f778d: [mlir] don't install tutorial libraries.

Revision Contents

PathSize
mlir/
examples/
transform/
Ch2/
lib/
4 lines
Ch3/
lib/
4 lines

Diff 532201

mlir/examples/transform/Ch2/lib/CMakeLists.txt

add_mlir_library( add_mlir_library(
# Library called MyExtension. # Library called MyExtension.
MyExtensionCh2 MyExtensionCh2
# Built from the following source files. # Built from the following source files.
MyExtension.cpp MyExtension.cpp
# Do not make this part of the main library distribution.
# Needed for the example only.
EXCLUDE_FROM_LIBMLIR
# Make includes visible without top-level path. # Make includes visible without top-level path.
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${PROJECT_SOURCE_DIR}/examples/transform/Ch2/include ${PROJECT_SOURCE_DIR}/examples/transform/Ch2/include
# Make sure ODS declaration and definitions are generated before compiling this. # Make sure ODS declaration and definitions are generated before compiling this.
DEPENDS DEPENDS
MyExtensionCh2IncGen MyExtensionCh2IncGen
# Link in the transform dialect, an all generated dialects. # Link in the transform dialect, an all generated dialects.
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRTransformDialect MLIRTransformDialect
MLIRFuncDialect MLIRFuncDialect
MLIRSCFDialect MLIRSCFDialect
) )

mlir/examples/transform/Ch3/lib/CMakeLists.txt

add_mlir_library( add_mlir_library(
# Library called MyExtension. # Library called MyExtension.
MyExtensionCh3 MyExtensionCh3
# Built from the following source files. # Built from the following source files.
MyExtension.cpp MyExtension.cpp
# Do not make this part of the main library distribution.
# Needed for the example only.
EXCLUDE_FROM_LIBMLIR
# Make includes visible without top-level path. # Make includes visible without top-level path.
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${PROJECT_SOURCE_DIR}/examples/transform/Ch3/include ${PROJECT_SOURCE_DIR}/examples/transform/Ch3/include
# Make sure ODS declaration and definitions are generated before compiling this. # Make sure ODS declaration and definitions are generated before compiling this.
DEPENDS DEPENDS
MyExtensionCh3IncGen MyExtensionCh3IncGen
# Link in the transform dialect, an all generated dialects. # Link in the transform dialect, an all generated dialects.
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRTransformDialect MLIRTransformDialect
MLIRFuncDialect MLIRFuncDialect
MLIRSCFDialect MLIRSCFDialect
) )