This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix memcmp interceptor to correctly use COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED
ClosedPublic

Authored by kubamracek on Dec 7 2015, 5:29 AM.

Details

Summary

The memcmp interceptor checks COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED only after it calls COMMON_INTERCEPTOR_ENTER, which causes an early process launch crash when running TSan in iOS simulator. Let's fix this by checking COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED as the very first thing in the interceptor.

Diff Detail

Repository
rL LLVM

Event Timeline

kubamracek updated this revision to Diff 42060.Dec 7 2015, 5:29 AM
kubamracek retitled this revision from to [tsan] Fix memcmp interceptor to correctly use COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED.
kubamracek updated this object.
kubamracek added reviewers: dvyukov, samsonov, glider, kcc.
kubamracek added subscribers: llvm-commits, zaks.anna.
dvyukov accepted this revision.Dec 7 2015, 5:38 AM
dvyukov edited edge metadata.
This revision is now accepted and ready to land.Dec 7 2015, 5:38 AM
This revision was automatically updated to reflect the committed changes.