This is an archive of the discontinued LLVM Phabricator instance.

[MISched][scheduleDump] Use stable_sort to prevent test failures.
ClosedPublic

Authored by fpetrogalli on Jun 13 2023, 4:10 AM.

Details

Summary

When building the compiler with -DLLVM_ENABLE_EXPENSIVE_CHECKS=ON,
sometimes resources that are dumped in scheduled traces gets reordered
even if they are booked in the same cycle. Using stable_sort
guarantees that such occasional reordering does not happen.

This change should fix failures like the one seen in
https://lab.llvm.org/buildbot/#/builders/16/builds/49592.

Diff Detail

Event Timeline

fpetrogalli created this revision.Jun 13 2023, 4:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 4:10 AM
fpetrogalli requested review of this revision.Jun 13 2023, 4:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 13 2023, 4:10 AM
RKSimon accepted this revision.Jun 13 2023, 4:30 AM

LGTM - cheers

This revision is now accepted and ready to land.Jun 13 2023, 4:30 AM
This revision was landed with ongoing or failed builds.Jun 13 2023, 5:43 AM
This revision was automatically updated to reflect the committed changes.