This is an archive of the discontinued LLVM Phabricator instance.

Differential D152662

[BOLT][NFC] Const-ify getDynamicRelocationAt
ClosedPublic

Authored by Amir on Jun 11 2023, 5:24 PM.

Details

Reviewers
rafauler
maksfb
Group Reviewers
Restricted Project
Commits
rG702fe36b7067: [BOLT][NFC] Const-ify getDynamicRelocationAt

Diff Detail

Event Timeline

Amir created this revision.Jun 11 2023, 5:24 PM
Herald added a reviewer: rafauler. · View Herald TranscriptJun 11 2023, 5:24 PM
Herald added a reviewer: maksfb. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: treapster, ayermolo. · View Herald Transcript
Amir requested review of this revision.Jun 11 2023, 5:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 11 2023, 5:24 PM
Herald added subscribers: llvm-commits, yota9. · View Herald Transcript
Harbormaster completed remote builds in B238070: Diff 530352.Jun 11 2023, 5:43 PM
maksfb accepted this revision.Jun 11 2023, 10:40 PM
This revision is now accepted and ready to land.Jun 11 2023, 10:40 PM
Closed by commit rG702fe36b7067: [BOLT][NFC] Const-ify getDynamicRelocationAt (authored by Amir). · Explain WhyJun 12 2023, 9:55 AM
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG702fe36b7067: [BOLT][NFC] Const-ify getDynamicRelocationAt.

Revision Contents

PathSize
bolt/
include/
bolt/
Core/
2 lines
lib/
Core/
5 lines

Diff 530562

bolt/include/bolt/Core/BinaryContext.h

Show First 20 Lines • Show All 1,159 Lines • ▼ Show 20 Linespublic:
} }
/// Register dynamic relocation at \p Address. /// Register dynamic relocation at \p Address.
void addDynamicRelocation(uint64_t Address, MCSymbol *Symbol, uint64_t Type, void addDynamicRelocation(uint64_t Address, MCSymbol *Symbol, uint64_t Type,
uint64_t Addend, uint64_t Value = 0); uint64_t Addend, uint64_t Value = 0);
/// Return a dynamic relocation registered at a given \p Address, or nullptr /// Return a dynamic relocation registered at a given \p Address, or nullptr
/// if there is no dynamic relocation at such address. /// if there is no dynamic relocation at such address.
const Relocation *getDynamicRelocationAt(uint64_t Address); const Relocation *getDynamicRelocationAt(uint64_t Address) const;
/// Remove registered relocation at a given \p Address. /// Remove registered relocation at a given \p Address.
bool removeRelocationAt(uint64_t Address); bool removeRelocationAt(uint64_t Address);
/// This function makes sure that symbols referenced by ambiguous relocations /// This function makes sure that symbols referenced by ambiguous relocations
/// are marked as immovable. For now, if a section relocation points at the /// are marked as immovable. For now, if a section relocation points at the
/// boundary between two symbols then those symbols are marked as immovable. /// boundary between two symbols then those symbols are marked as immovable.
void markAmbiguousRelocations(BinaryData &BD, const uint64_t Address); void markAmbiguousRelocations(BinaryData &BD, const uint64_t Address);
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines

bolt/lib/Core/BinaryContext.cpp

Show First 20 Lines • Show All 2,094 Lines • ▼ Show 20 Lines
const Relocation *BinaryContext::getRelocationAt(uint64_t Address) const { const Relocation *BinaryContext::getRelocationAt(uint64_t Address) const {
ErrorOr<const BinarySection &> Section = getSectionForAddress(Address); ErrorOr<const BinarySection &> Section = getSectionForAddress(Address);
if (!Section) if (!Section)
return nullptr; return nullptr;
return Section->getRelocationAt(Address - Section->getAddress()); return Section->getRelocationAt(Address - Section->getAddress());
} }
const Relocation *BinaryContext::getDynamicRelocationAt(uint64_t Address) { const Relocation *
ErrorOr<BinarySection &> Section = getSectionForAddress(Address); BinaryContext::getDynamicRelocationAt(uint64_t Address) const {
ErrorOr<const BinarySection &> Section = getSectionForAddress(Address);
if (!Section) if (!Section)
return nullptr; return nullptr;
return Section->getDynamicRelocationAt(Address - Section->getAddress()); return Section->getDynamicRelocationAt(Address - Section->getAddress());
} }
void BinaryContext::markAmbiguousRelocations(BinaryData &BD, void BinaryContext::markAmbiguousRelocations(BinaryData &BD,
const uint64_t Address) { const uint64_t Address) {
▲ Show 20 Lines • Show All 254 Lines • Show Last 20 Lines