[clang-tidy] run-clang-tidy: forward warnings-as-errors argument

[indev29]

Summary

Forward warnings-as-errors argument to clang-tidy.

[PiotrZSL]

LGTM

[indev29]

@PiotrZSL could you please commit? I don't think I have access yet.

[PiotrZSL]

In D152625#4413242, @indev29 wrote:

@PiotrZSL could you please commit? I don't think I have access yet.

Author & Email please for git, under which should it be delivered.

[indev29]

In D152625#4413366, @PiotrZSL wrote:

In D152625#4413242, @indev29 wrote:

@PiotrZSL could you please commit? I don't think I have access yet.

Author & Email please for git, under which should it be delivered.

indev <[e-mail]>

clang-tools-extra/clang-tidy/tool/run-clang-tidy.py

def get_tidy_invocation(
     extra_arg,
     extra_arg_before,
     quiet,
     config_file_path,
     config,
     line_filter,
     use_color,
     plugins,
+    warnings_as_errors,
 ):
     """Gets a command line for clang-tidy."""
     start = [clang_tidy_binary]
     if allow_enabling_alpha_checkers:
         start.append("-allow-enabling-analyzer-alpha-checkers")
     if header_filter is not None:
         start.append("-header-filter=" + header_filter)
     if line_filter is not None:
):
     if quiet:
         start.append("-quiet")
     if config_file_path:
         start.append("--config-file=" + config_file_path)
     elif config:
         start.append("-config=" + config)
     for plugin in plugins:
         start.append("-load=" + plugin)
+    if warnings_as_errors:
+        start.append("--warnings-as-errors=" + warnings_as_errors)
     start.append(f)
     return start
 
 
 def merge_replacement_files(tmpdir, mergefile):
     """Merge all replacement files in a directory into a single file"""
     # The fixes suggested by clang-tidy >= 4.0.0 are given under
     # the top level key 'Diagnostics' in the output yaml files
while True:
             args.extra_arg,
             args.extra_arg_before,
             args.quiet,
             args.config_file,
             args.config,
             args.line_filter,
             args.use_color,
             args.plugins,
+            args.warnings_as_errors,
         )
 
         proc = subprocess.Popen(
             invocation, stdout=subprocess.PIPE, stderr=subprocess.PIPE
         )
         output, err = proc.communicate()
         if proc.returncode != 0:
             if proc.returncode < 0:
def main():
     )
     parser.add_argument(
         "-load",
         dest="plugins",
         action="append",
         default=[],
         help="Load the specified plugin in clang-tidy.",
     )
+    parser.add_argument(
+        "-warnings-as-errors",
+        default=None,
+        help="Upgrades warnings to errors. Same format as " "'-checks'",
+    )
     args = parser.parse_args()
 
     db_path = "compile_commands.json"
 
     if args.build_path is not None:
         build_path = args.build_path
     else:
         # Find our database
try:
             args.extra_arg,
             args.extra_arg_before,
             args.quiet,
             args.config_file,
             args.config,
             args.line_filter,
             args.use_color,
             args.plugins,
+            args.warnings_as_errors,
         )
         invocation.append("-list-checks")
         invocation.append("-")
         if args.quiet:
             # Even with -quiet we still want to check if we can call clang-tidy.
             with open(os.devnull, "w") as dev_null:
                 subprocess.check_call(invocation, stdout=dev_null)
         else: