This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Add basic support for gfx11xx
ClosedPublic

Authored by giuseros on Jun 8 2023, 8:29 AM.

Details

Summary

This patch fixes a minor issue in AMDGPUToROCDL to add gfx11 support in MLIR

Diff Detail

Event Timeline

giuseros created this revision.Jun 8 2023, 8:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 8 2023, 8:29 AM
giuseros requested review of this revision.Jun 8 2023, 8:29 AM

@giuseros I'm willing to approve this if you add me as a reviewer.

Though can you update the commit message to mention the bug you're fixing and that the fix here is to set the correct buffer flags on gfx11 (because gfx11 acts like gfx10 for the purposes of those instructions)?

giuseros updated this revision to Diff 529672.Jun 8 2023, 10:32 AM

Updating the commit message

krzysz00 accepted this revision.Jun 8 2023, 10:43 AM
This revision is now accepted and ready to land.Jun 8 2023, 10:43 AM
giuseros updated this revision to Diff 529676.Jun 8 2023, 10:45 AM

Adding github issue reference in the commit message

arsenm added a subscriber: arsenm.Jun 8 2023, 10:46 AM

Missing test

giuseros updated this revision to Diff 530514.Jun 12 2023, 8:12 AM

Adding test

This revision was automatically updated to reflect the committed changes.