This is an archive of the discontinued LLVM Phabricator instance.

[mlir][transform][NFC] Extract getConsumedHandleOpOperands helper function
ClosedPublic

Authored by springerm on Jun 7 2023, 8:36 AM.

Details

Summary

This function is extracted from TransformState::applyTransform.

Diff Detail

Event Timeline

springerm created this revision.Jun 7 2023, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 8:36 AM
springerm requested review of this revision.Jun 7 2023, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 8:36 AM
ftynse accepted this revision.Jun 9 2023, 12:37 AM
ftynse added inline comments.
mlir/lib/Dialect/Transform/IR/TransformInterfaces.cpp
1585

I see this was already there before this refactoring, but it doesn't look like this needs to be a set. OpOperands are unique by construction, so let's use a vector instead. It will also remove the implementation-defined behavior in traversals.

This revision is now accepted and ready to land.Jun 9 2023, 12:37 AM
springerm marked an inline comment as done.Jun 9 2023, 2:27 AM