This is an archive of the discontinued LLVM Phabricator instance.

change checking for auto-init metadata to use `equalsStr` instead of casing MDOperand nodes.
ClosedPublic

Authored by zjaffal on Jun 7 2023, 7:11 AM.

Details

Summary

Since MD_annotation metadata now supports having mutliple strings in the annotation node. casing Operand to string directly will cause a crash. When checking if MDOperand equals str you can use equalsStr method.

Diff Detail

Unit TestsFailed

Event Timeline

zjaffal created this revision.Jun 7 2023, 7:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 7:11 AM
zjaffal requested review of this revision.Jun 7 2023, 7:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 7:11 AM
serge-sans-paille accepted this revision.Jun 7 2023, 7:31 AM
This revision is now accepted and ready to land.Jun 7 2023, 7:31 AM
This revision was landed with ongoing or failed builds.Jun 8 2023, 7:58 AM
This revision was automatically updated to reflect the committed changes.