Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D152349

[InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left
ClosedPublic
Actions

Authored by goldstein.w.n on Jun 7 2023, 1:15 AM.

Details

Reviewers
nikic
spatel
Commits
rG5189eff3459c: [InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left
Summary

We canonicalize rotate-right -> rotate-left in other places. Makes
sense to do so here as well.
Proof: https://alive2.llvm.org/ce/z/HL3TpK

Diff Detail

Unit TestsFailed
View All

TimeTest
40 msx64 debian > LLVM.Transforms/InstCombine::icmp-rotate.ll

Event Timeline

goldstein.w.n created this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
Herald added subscribers: StephenFan, hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a parent revision: D152348: [InstCombine] Transform (icmp eq/ne rotate(X,AX),rotate(Y,AY)) -> (icmp eq/ne rotate(Y,AX-AY)).Jun 7 2023, 1:16 AM
goldstein.w.n retitled this revision from [InstCombine] Transform (icmp eq/ne rotate(X,A0),rotate(X,A1)) -> (icmp eq/ne rotate(X,A0-A1)) to [InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left.Jun 7 2023, 2:02 AM
goldstein.w.n edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B237201: Diff 529210.Jun 7 2023, 2:44 AM
goldstein.w.n updated this revision to Diff 529371.Jun 7 2023, 11:00 AM

Use Builder.CreateIntrinsic

Harbormaster completed remote builds in B237320: Diff 529371.Jun 7 2023, 12:13 PM
nikic accepted this revision.Jun 7 2023, 12:14 PM

LGTM

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
5053
This revision is now accepted and ready to land.Jun 7 2023, 12:14 PM
goldstein.w.n updated this revision to Diff 529406.Jun 7 2023, 12:36 PM

Rebase

goldstein.w.n updated this revision to Diff 529415.Jun 7 2023, 1:16 PM

Rebase

Harbormaster completed remote builds in B237354: Diff 529415.Jun 7 2023, 2:04 PM
goldstein.w.n updated this revision to Diff 529721.Jun 8 2023, 2:10 PM

Rebase

Harbormaster completed remote builds in B237582: Diff 529721.Jun 8 2023, 3:06 PM
Closed by commit rG5189eff3459c: [InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left (authored by goldstein.w.n). · Explain WhyJun 10 2023, 12:39 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG5189eff3459c: [InstCombine] Canonicalize (icmp eq/ne X, rotate(X)) to always use rotate-left.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Transforms/
InstCombine/
13 lines
test/
Transforms/
InstCombine/
6 lines

Diff 529415

View Options

llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp

Loading...
View Options

llvm/test/Transforms/InstCombine/icmp-equality-rotate.ll

Loading...