This is an archive of the discontinued LLVM Phabricator instance.

Differential D152347

[InstCombine] Add tests for equality `icmp` with rotates; NFC
ClosedPublic

Authored by goldstein.w.n on Jun 7 2023, 1:15 AM.

Details

Reviewers
nikic
spatel
Commits
rG1ce0265230c0: [InstCombine] Add tests for equality `icmp` with rotates; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
goldstein.w.n requested review of this revision.Jun 7 2023, 1:15 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 7 2023, 1:15 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D152348: [InstCombine] Transform (icmp eq/ne rotate(X,AX),rotate(Y,AY)) -> (icmp eq/ne rotate(Y,AX-AY)).Jun 7 2023, 1:16 AM
nikic added a comment.Jun 7 2023, 2:00 AM

Missing negative test with non-equality comparison.

Harbormaster completed remote builds in B237199: Diff 529208.Jun 7 2023, 2:22 AM
goldstein.w.n added a comment.Jun 7 2023, 10:59 AM
In D152347#4402518, @nikic wrote:

Missing negative test with non-equality comparison.

Done.

goldstein.w.n updated this revision to Diff 529369.Jun 7 2023, 11:00 AM

Add non-equality failure cases

Harbormaster completed remote builds in B237318: Diff 529369.Jun 7 2023, 12:04 PM
goldstein.w.n updated this revision to Diff 529403.Jun 7 2023, 12:34 PM

Add tests for rotate(X) with rotate(Y)

goldstein.w.n updated this revision to Diff 529404.Jun 7 2023, 12:36 PM

Rebase

nikic accepted this revision.Jun 7 2023, 12:56 PM

LGTM

llvm/test/Transforms/InstCombine/icmp-equality-rotate.ll
41

Can also add a test where the rotate and icmp operands are different.

This revision is now accepted and ready to land.Jun 7 2023, 12:56 PM
goldstein.w.n updated this revision to Diff 529413.Jun 7 2023, 1:15 PM

Add tests for comparing rorr to another var

goldstein.w.n marked an inline comment as done.Jun 7 2023, 1:16 PM
Harbormaster completed remote builds in B237352: Diff 529413.Jun 7 2023, 1:50 PM
goldstein.w.n updated this revision to Diff 529719.Jun 8 2023, 2:09 PM

Rebase

Harbormaster completed remote builds in B237580: Diff 529719.Jun 8 2023, 3:47 PM
Closed by commit rG1ce0265230c0: [InstCombine] Add tests for equality `icmp` with rotates; NFC (authored by goldstein.w.n). · Explain WhyJun 10 2023, 12:39 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rG1ce0265230c0: [InstCombine] Add tests for equality `icmp` with rotates; NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
163 lines

Diff 530235

llvm/test/Transforms/InstCombine/icmp-equality-rotate.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s
declare i8 @llvm.fshl.i8(i8, i8, i8)
declare i8 @llvm.fshr.i8(i8, i8, i8)
declare void @use.i8(i8)
define i1 @cmpeq_rorr_to_rorl(i8 %x, i8 %C) {
; CHECK-LABEL: @cmpeq_rorr_to_rorl(
; CHECK-NEXT: [[X_RORR:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[X_RORR]], [[X]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C)
%r = icmp eq i8 %x_rorr, %x
ret i1 %r
}
define i1 @cmpeq_rorr_to_rorl_non_equality_fail(i8 %x, i8 %C) {
; CHECK-LABEL: @cmpeq_rorr_to_rorl_non_equality_fail(
; CHECK-NEXT: [[X_RORR:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[X_RORR]], [[X]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C)
%r = icmp ult i8 %x_rorr, %x
ret i1 %r
}
define i1 @cmpeq_rorr_to_rorl_cmp_against_wrong_val_fail(i8 %x, i8 %C) {
; CHECK-LABEL: @cmpeq_rorr_to_rorl_cmp_against_wrong_val_fail(
; CHECK-NEXT: [[X_RORR:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[X_RORR]], [[C]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C)
%r = icmp ult i8 %x_rorr, %C
ret i1 %r
}
define i1 @cmpeq_rorr_to_rorl_non_ror_fail(i8 %x, i8 %C) {
; CHECK-LABEL: @cmpeq_rorr_to_rorl_non_ror_fail(
nikicUnsubmitted
Done
ReplyInline Actions

Can also add a test where the rotate and icmp operands are different.

nikic: Can also add a test where the rotate and icmp operands are different.
; CHECK-NEXT: [[X_RORR:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[C:%.*]], i8 [[C]])
; CHECK-NEXT: [[R:%.*]] = icmp ult i8 [[X_RORR]], [[X]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr = call i8 @llvm.fshr.i8(i8 %x, i8 %C, i8 %C)
%r = icmp ult i8 %x_rorr, %x
ret i1 %r
}
define i1 @cmpeq_rorr_to_rorl_multiuse_fail(i8 %x, i8 %C) {
; CHECK-LABEL: @cmpeq_rorr_to_rorl_multiuse_fail(
; CHECK-NEXT: [[X_RORR:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C:%.*]])
; CHECK-NEXT: call void @use.i8(i8 [[X_RORR]])
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[X_RORR]], [[X]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C)
call void @use.i8(i8 %x_rorr)
%r = icmp eq i8 %x_rorr, %x
ret i1 %r
}
define i1 @cmpne_rorr_rorr(i8 %x, i8 %C0, i8 %C1) {
; CHECK-LABEL: @cmpne_rorr_rorr(
; CHECK-NEXT: [[X_RORR0:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C0:%.*]])
; CHECK-NEXT: [[X_RORR1:%.*]] = call i8 @llvm.fshr.i8(i8 [[X]], i8 [[X]], i8 [[C1:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[X_RORR0]], [[X_RORR1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr0 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C0)
%x_rorr1 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C1)
%r = icmp ne i8 %x_rorr0, %x_rorr1
ret i1 %r
}
define i1 @cmpne_rorrX_rorrY(i8 %x, i8 %y, i8 %C0, i8 %C1) {
; CHECK-LABEL: @cmpne_rorrX_rorrY(
; CHECK-NEXT: [[X_RORR0:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C0:%.*]])
; CHECK-NEXT: [[Y_RORR1:%.*]] = call i8 @llvm.fshr.i8(i8 [[Y:%.*]], i8 [[Y]], i8 [[C1:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[X_RORR0]], [[Y_RORR1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr0 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C0)
%y_rorr1 = call i8 @llvm.fshr.i8(i8 %y, i8 %y, i8 %C1)
%r = icmp ne i8 %x_rorr0, %y_rorr1
ret i1 %r
}
define i1 @cmpne_rorr_rorr_non_equality_fail(i8 %x, i8 %C0, i8 %C1) {
; CHECK-LABEL: @cmpne_rorr_rorr_non_equality_fail(
; CHECK-NEXT: [[X_RORR0:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C0:%.*]])
; CHECK-NEXT: [[X_RORR1:%.*]] = call i8 @llvm.fshr.i8(i8 [[X]], i8 [[X]], i8 [[C1:%.*]])
; CHECK-NEXT: [[R:%.*]] = icmp sge i8 [[X_RORR0]], [[X_RORR1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr0 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C0)
%x_rorr1 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C1)
%r = icmp sge i8 %x_rorr0, %x_rorr1
ret i1 %r
}
define i1 @cmpne_rorr_rorl_todo_mismatch_C(i8 %x, i8 %C0, i8 %C1) {
; CHECK-LABEL: @cmpne_rorr_rorl_todo_mismatch_C(
; CHECK-NEXT: [[X_RORR0:%.*]] = call i8 @llvm.fshr.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C0:%.*]])
; CHECK-NEXT: [[X_RORL1:%.*]] = call i8 @llvm.fshl.i8(i8 [[X]], i8 [[X]], i8 3)
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[X_RORR0]], [[X_RORL1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorr0 = call i8 @llvm.fshr.i8(i8 %x, i8 %x, i8 %C0)
%x_rorl1 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 3)
%r = icmp ne i8 %x_rorr0, %x_rorl1
ret i1 %r
}
define i1 @cmpne_rorl_rorl_multiuse1_fail(i8 %x, i8 %C0) {
; CHECK-LABEL: @cmpne_rorl_rorl_multiuse1_fail(
; CHECK-NEXT: [[X_RORL0:%.*]] = call i8 @llvm.fshl.i8(i8 [[X:%.*]], i8 [[X]], i8 [[C0:%.*]])
; CHECK-NEXT: [[X_RORL1:%.*]] = call i8 @llvm.fshl.i8(i8 [[X]], i8 [[X]], i8 3)
; CHECK-NEXT: call void @use.i8(i8 [[X_RORL1]])
; CHECK-NEXT: [[R:%.*]] = icmp ne i8 [[X_RORL0]], [[X_RORL1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorl0 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 %C0)
%x_rorl1 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 3)
call void @use.i8(i8 %x_rorl1)
%r = icmp ne i8 %x_rorl0, %x_rorl1
ret i1 %r
}
define i1 @cmpeq_rorlXC_rorlYC_multiuse1(i8 %x, i8 %y) {
; CHECK-LABEL: @cmpeq_rorlXC_rorlYC_multiuse1(
; CHECK-NEXT: [[X_RORL0:%.*]] = call i8 @llvm.fshl.i8(i8 [[X:%.*]], i8 [[X]], i8 6)
; CHECK-NEXT: [[Y_RORL1:%.*]] = call i8 @llvm.fshl.i8(i8 [[Y:%.*]], i8 [[Y]], i8 3)
; CHECK-NEXT: call void @use.i8(i8 [[Y_RORL1]])
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[X_RORL0]], [[Y_RORL1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorl0 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 6)
%y_rorl1 = call i8 @llvm.fshl.i8(i8 %y, i8 %y, i8 3)
call void @use.i8(i8 %y_rorl1)
%r = icmp eq i8 %x_rorl0, %y_rorl1
ret i1 %r
}
define i1 @cmpeq_rorlC_rorlC_multiuse2_fail(i8 %x) {
; CHECK-LABEL: @cmpeq_rorlC_rorlC_multiuse2_fail(
; CHECK-NEXT: [[X_RORL0:%.*]] = call i8 @llvm.fshl.i8(i8 [[X:%.*]], i8 [[X]], i8 6)
; CHECK-NEXT: [[X_RORL1:%.*]] = call i8 @llvm.fshl.i8(i8 [[X]], i8 [[X]], i8 3)
; CHECK-NEXT: call void @use.i8(i8 [[X_RORL0]])
; CHECK-NEXT: call void @use.i8(i8 [[X_RORL1]])
; CHECK-NEXT: [[R:%.*]] = icmp eq i8 [[X_RORL0]], [[X_RORL1]]
; CHECK-NEXT: ret i1 [[R]]
;
%x_rorl0 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 6)
%x_rorl1 = call i8 @llvm.fshl.i8(i8 %x, i8 %x, i8 3)
call void @use.i8(i8 %x_rorl0)
call void @use.i8(i8 %x_rorl1)
%r = icmp eq i8 %x_rorl0, %x_rorl1
ret i1 %r
}