This is an archive of the discontinued LLVM Phabricator instance.

[hwasan] Only run tests for Android
Needs ReviewPublic

Authored by aeubanks on Jun 6 2023, 4:05 PM.

Details

Reviewers
eugenis
fmayer
Summary

IIUC, D144660 shows that we only ever set config.has_lld for Android, (unless you manually set -DCOMPILER_RT_HAS_LLD=ON).

Running these tests on x86_64 Linux causes some of them crash, see https://crbug.com/1451819.

Diff Detail

Event Timeline

aeubanks created this revision.Jun 6 2023, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 4:05 PM
aeubanks requested review of this revision.Jun 6 2023, 4:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 4:05 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
fmayer added a comment.Jun 6 2023, 5:06 PM

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

makes sense, but is the arm64 linux bot actually running the hwasan tests, or are they all disabled currently?

there were a lot of hwasan tests failing on linux x64 (>40), is that expected?

fmayer added a comment.Jun 7 2023, 3:05 PM

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

makes sense, but is the arm64 linux bot actually running the hwasan tests, or are they all disabled currently?

It is actually running them.

there were a lot of hwasan tests failing on linux x64 (>40), is that expected?

That is unexpected.

fmayer added a comment.Jun 7 2023, 3:21 PM

I don't think we want to disable HWASan tests on Linux generally. If a test has problems on x86, we should either fix that or disable that test only.

We also have an arm64 Linux buildbot, which we definitely don't want to disable.

makes sense, but is the arm64 linux bot actually running the hwasan tests, or are they all disabled currently?

It is actually running them.

there were a lot of hwasan tests failing on linux x64 (>40), is that expected?

That is unexpected.

% ninja -C build check-hwasan
ninja: Entering directory `build'
[0/1] Running the HWAddressSanitizer tests

Testing Time: 7.14s
  Unsupported      : 32
  Passed           : 52
  Expectedly Failed:  6