This is an archive of the discontinued LLVM Phabricator instance.

[GlobalIsel][X86] Legalize G_SELECT
AbandonedPublic

Authored by tschuett on Jun 6 2023, 6:53 AM.

Details

Reviewers
RKSimon
arsenm
Summary

With bug fixes. The legalizer got more powerful over the last weeks.

Diff Detail

Event Timeline

tschuett created this revision.Jun 6 2023, 6:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 6:53 AM
tschuett requested review of this revision.Jun 6 2023, 6:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2023, 6:53 AM
arsenm added inline comments.Jun 6 2023, 6:54 AM
llvm/test/CodeGen/X86/GlobalISel/legalize-select.mir
27

Try tests with some other address spaces (in particular the 32-bit ones on x64)

RKSimon added inline comments.Jun 6 2023, 7:06 AM
llvm/test/CodeGen/X86/GlobalISel/legalize-leading-zeros.mir
3

Can this now be reduced to:

# RUN: llc -mtriple=i386-linux-gnu -mattr=+lzcnt -run-pass=legalizer %s -o - | FileCheck %s --check-prefixes=CHECK,X86
llvm/test/CodeGen/X86/GlobalISel/legalize-trailing-zeros-undef.mir
3

Can this now be reduced to:

# RUN: llc -mtriple=i386-linux-gnu -run-pass=legalizer %s -o - | FileCheck %s --check-prefixes=CHECK,X86
llvm/test/CodeGen/X86/GlobalISel/legalize-trailing-zeros.mir
3

Can this now be reduced to:

# RUN: llc -mtriple=i386-linux-gnu -mattr=+bmi -run-pass=legalizer %s -o - | FileCheck %s --check-prefixes=CHECK,X86
tschuett abandoned this revision.Jun 6 2023, 9:45 AM