[AppleAccelTable][NFC] Improve code readability

[fdeazeve]

Summary

This commit does a few minor NFC cleanups:

• A variable was called "Atom", probably trying to claim it was an AtomType.

This was incorrect, it is actually a FormValue.

• LLVM provides a zip_equal to express the intent of asserting ranges with the

same size. We change the lookup method to use that.

• The use of tuples made the code slightly difficult to follow, as such we

unpack the tuple with structure binding to improve readability.

Depends on D152157

[fdeazeve]

Update base

[fdeazeve]

Rebased

llvm/lib/DebugInfo/DWARF/DWARFAcceleratorTable.cpp

AppleAcceleratorTable::Entry::Entry(
     : HdrData(&HdrData) {
   Values.reserve(HdrData.Atoms.size());
   for (const auto &Atom : HdrData.Atoms)
     Values.push_back(DWARFFormValue(Atom.second));
 }
 
 void AppleAcceleratorTable::Entry::extract(
     const AppleAcceleratorTable &AccelTable, uint64_t *Offset) {
-  for (auto &Atom : Values)
-    Atom.extractValue(AccelTable.AccelSection, Offset, AccelTable.FormParams);
+  for (auto &FormValue : Values)
+    FormValue.extractValue(AccelTable.AccelSection, Offset,
+                           AccelTable.FormParams);
 }
 
 std::optional<DWARFFormValue>
-AppleAcceleratorTable::Entry::lookup(HeaderData::AtomType Atom) const {
+AppleAcceleratorTable::Entry::lookup(HeaderData::AtomType AtomToFind) const {
   assert(HdrData && "Dereferencing end iterator?");
   assert(HdrData->Atoms.size() == Values.size());
-  for (auto Tuple : zip_first(HdrData->Atoms, Values)) {
-    if (std::get<0>(Tuple).first == Atom)
-      return std::get<1>(Tuple);
-  }
+  for (auto [Atom, FormValue] : zip_equal(HdrData->Atoms, Values))
+    if (Atom.first == AtomToFind)
+      return FormValue;
   return std::nullopt;
 }
 
 std::optional<uint64_t>
 AppleAcceleratorTable::Entry::getDIESectionOffset() const {
   return HdrData->extractOffset(lookup(dwarf::DW_ATOM_die_offset));
 }