[mlir][Toy] Remove unnecessary transpose from chapter 1 example

[aportnoy]

Summary

The call to 'multiply_transpose' in the initialization of the variable 'f' was
intended to have a shape mismatch. However the variable 'a' has shape <2, 3> and
the variable 'c' has shape <3, 2>, so the arguments 'transpose(a)' and 'c' have
in fact compatible shapes (<3, 2> both), the opposite of what is wanted here.
This commit removes the transpose so that arguments 'a' and 'c' have
incompatible shapes <2, 3> and <3, 2>, respectively.

[aportnoy]

The Windows build failed with multiple errors of the form:

C:\ws\w4\llvm-project\premerge-checks\llvm\include\llvm/ADT/PointerIntPair.h(83): fatal error C1060: compiler is out of heap space

Example: https://buildkite.com/llvm-project/premerge-checks/builds/155745#018877be-2e2d-4da8-a400-fa2c7fb3e0dd/385-5565

[aportnoy]

@mehdi_amini Thank you for taking a look! I don't have commit access.

[manas]

Can you rebase it to latest and restart buildbot? I see no reason it should fail with an OOM.

[aportnoy]

@manas Thank you for looking at this! After I rebase onto main using git, what are my steps to update this revision? How do I restart the buildbot? Or does it run automatically after I update the revision? Sorry, first time using the LLVM workflow.

[manas]

In D151897#4400309, @aportnoy wrote:

@manas Thank you for looking at this! After I rebase onto main using git, what are my steps to update this revision? How do I restart the buildbot? Or does it run automatically after I update the revision? Sorry, first time using the LLVM workflow.

I am assuming you are arcanist. You should again do arc diff and buildbot will restart automatically.

[aportnoy]

Rebase onto upstream main

[aportnoy]

I did arc diff --update D151897.

[mehdi_amini]

Sorry I meant to push it before but I was trying to figure an issue this patch is raising: we should trigger a shape inference error and we don't anymore!

[aportnoy]

@mehdi_amini Got it, thank you. If I get to the relevant part in the tutorial, I'll try to fix that (unless you or someone else does it sooner).

mlir/docs/Tutorials/Toy/Ch-1.md

def main() {
   # A second call to `multiply_transpose` with <2, 3> for both arguments will
   # reuse the previously specialized and inferred version and return <3, 2>.
   var d = multiply_transpose(b, a);
 
   # A new call with <3, 2> (instead of <2, 3>) for both dimensions will
   # trigger another specialization of `multiply_transpose`.
   var e = multiply_transpose(c, d);
 
-  # Finally, calling into `multiply_transpose` with incompatible shape will
-  # trigger a shape inference error.
-  var f = multiply_transpose(transpose(a), c);
+  # Finally, calling into `multiply_transpose` with incompatible shapes
+  # (<2, 3> and <3, 2>) will trigger a shape inference error.
+  var f = multiply_transpose(a, c);
 }
 ```
 
 ## The AST
 
 The AST from the above code is fairly straightforward; here is a dump of it:
 
 ```
 Module:
   Function 
-    Proto 'multiply_transpose' @test/Examples/Toy/Ch1/ast.toy:4:1'
+    Proto 'multiply_transpose' @test/Examples/Toy/Ch1/ast.toy:4:1
     Params: [a, b]
     Block {
       Return
         BinOp: * @test/Examples/Toy/Ch1/ast.toy:5:25
           Call 'transpose' [ @test/Examples/Toy/Ch1/ast.toy:5:10
             var: a @test/Examples/Toy/Ch1/ast.toy:5:20
           ]
           Call 'transpose' [ @test/Examples/Toy/Ch1/ast.toy:5:25
             var: b @test/Examples/Toy/Ch1/ast.toy:5:35
           ]
     } // Block
   Function 
-    Proto 'main' @test/Examples/Toy/Ch1/ast.toy:8:1'
+    Proto 'main' @test/Examples/Toy/Ch1/ast.toy:8:1
     Params: []
     Block {
       VarDecl a<> @test/Examples/Toy/Ch1/ast.toy:11:3
         Literal: <2, 3>[ <3>[ 1.000000e+00, 2.000000e+00, 3.000000e+00], <3>[ 4.000000e+00, 5.000000e+00, 6.000000e+00]] @test/Examples/Toy/Ch1/ast.toy:11:11
       VarDecl b<2, 3> @test/Examples/Toy/Ch1/ast.toy:15:3
         Literal: <6>[ 1.000000e+00, 2.000000e+00, 3.000000e+00, 4.000000e+00, 5.000000e+00, 6.000000e+00] @test/Examples/Toy/Ch1/ast.toy:15:17
       VarDecl c<> @test/Examples/Toy/Ch1/ast.toy:19:3
         Call 'multiply_transpose' [ @test/Examples/Toy/Ch1/ast.toy:19:11
           var: a @test/Examples/Toy/Ch1/ast.toy:19:30
           var: b @test/Examples/Toy/Ch1/ast.toy:19:33
         ]
       VarDecl d<> @test/Examples/Toy/Ch1/ast.toy:22:3
         Call 'multiply_transpose' [ @test/Examples/Toy/Ch1/ast.toy:22:11
           var: b @test/Examples/Toy/Ch1/ast.toy:22:30
           var: a @test/Examples/Toy/Ch1/ast.toy:22:33
         ]
       VarDecl e<> @test/Examples/Toy/Ch1/ast.toy:25:3
         Call 'multiply_transpose' [ @test/Examples/Toy/Ch1/ast.toy:25:11
           var: c @test/Examples/Toy/Ch1/ast.toy:25:30
           var: d @test/Examples/Toy/Ch1/ast.toy:25:33
         ]
       VarDecl f<> @test/Examples/Toy/Ch1/ast.toy:28:3
         Call 'multiply_transpose' [ @test/Examples/Toy/Ch1/ast.toy:28:11
-          Call 'transpose' [ @test/Examples/Toy/Ch1/ast.toy:28:30
-            var: a @test/Examples/Toy/Ch1/ast.toy:28:40
-          ]
-          var: c @test/Examples/Toy/Ch1/ast.toy:28:44
+          var: a @test/Examples/Toy/Ch1/ast.toy:28:30
+          var: c @test/Examples/Toy/Ch1/ast.toy:28:33
         ]
     } // Block
 ```
 
 You can reproduce this result and play with the example in the
 `examples/toy/Ch1/` directory; try running `path/to/BUILD/bin/toyc-ch1
 test/Examples/Toy/Ch1/ast.toy -emit=ast`.
 
 The code for the lexer is fairly straightforward; it is all in a single header:
 `examples/toy/Ch1/include/toy/Lexer.h`. The parser can be found in
 `examples/toy/Ch1/include/toy/Parser.h`; it is a recursive descent parser. If
 you are not familiar with such a Lexer/Parser, these are very similar to the
 LLVM Kaleidoscope equivalent that are detailed in the first two chapters of the
 [Kaleidoscope Tutorial](https://llvm.org/docs/tutorial/MyFirstLanguageFrontend/LangImpl02.html).
 
 The [next chapter](Ch-2.md) will demonstrate how to convert this AST into MLIR.

mlir/test/Examples/Toy/Ch1/ast.toy

def main() {
   # arguments and deduce a return type of <3, 2> in initialization of `c`.
   var c = multiply_transpose(a, b);
   # A second call to `multiply_transpose` with <2, 3> for both arguments will
   # reuse the previously specialized and inferred version and return `<3, 2>`
   var d = multiply_transpose(b, a);
   # A new call with `<3, 2>` for both dimension will trigger another
   # specialization of `multiply_transpose`.
   var e = multiply_transpose(c, d);
-  # Finally, calling into `multiply_transpose` with incompatible shape will
-  # trigger a shape inference error.
-  var f = multiply_transpose(transpose(a), c);
+  # Finally, calling into `multiply_transpose` with incompatible shapes
+  # (<2, 3> and <3, 2>) will trigger a shape inference error.
+  var f = multiply_transpose(a, c);
 }
 
 
 # CHECK: Module:
 # CHECK-NEXT:     Function
 # CHECK-NEXT:       Proto 'multiply_transpose' @{{.*}}ast.toy:4:1
 # CHECK-NEXT:       Params: [a, b]
 # CHECK-NEXT:       Block {

 # CHECK-NEXT:           ]
 # CHECK-NEXT:         VarDecl e<> @{{.*}}ast.toy:25:3
 # CHECK-NEXT:           Call 'multiply_transpose' [ @{{.*}}ast.toy:25:11
 # CHECK-NEXT:             var: c @{{.*}}ast.toy:25:30
 # CHECK-NEXT:             var: d @{{.*}}ast.toy:25:33
 # CHECK-NEXT:           ]
 # CHECK-NEXT:         VarDecl f<> @{{.*}}ast.toy:28:3
 # CHECK-NEXT:           Call 'multiply_transpose' [ @{{.*}}ast.toy:28:11
-# CHECK-NEXT:             Call 'transpose' [ @{{.*}}ast.toy:28:30
-# CHECK-NEXT:               var: a @{{.*}}ast.toy:28:40
-# CHECK-NEXT:             ]
-# CHECK-NEXT:             var: c @{{.*}}ast.toy:28:44
-# CHECK-NEXT:           ]
-
+# CHECK-NEXT:             var: a @{{.*}}ast.toy:28:30
+# CHECK-NEXT:             var: c @{{.*}}ast.toy:28:33
+# CHECK-NEXT:           ]
+# CHECK-NEXT:       } // Block