This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][Bufferization] Improve documentation of introduction and `summary`s
ClosedPublic

Authored by rikhuijzer on May 31 2023, 12:08 PM.

Details

Summary

This patch suggests to add a sentence in the introduction which clarifies
the aim of the dialect in one sentence. I hope that I understood it correctly.

For the summary fields, I have scrolled through the Bufferization page
(https://mlir.llvm.org/docs/Bufferization) and added missing summaries
or standardized existing ones to make the summaries easier to read.

Diff Detail

Event Timeline

rikhuijzer created this revision.May 31 2023, 12:08 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 31 2023, 12:08 PM
rikhuijzer requested review of this revision.May 31 2023, 12:08 PM
aartbik added inline comments.May 31 2023, 12:42 PM
mlir/include/mlir/Dialect/Bufferization/IR/BufferizationOps.td
211

this is not just for sparse storage format

(seems a copy and past from when we merged dense/sparse tensor bufferization ops)

springerm accepted this revision.May 31 2023, 11:44 PM

looks good with Aart's comment addressed

This revision is now accepted and ready to land.May 31 2023, 11:44 PM
rikhuijzer updated this revision to Diff 527338.Jun 1 2023, 2:45 AM

Update outdated sentence

Thanks both Aart Bik and Matthias Springer for reviewing this patch.

If you agree with the patch after this change, feel free to commit since
I do not have permissions for that.