fix printf test

[kuhar]

Do we need this separately from https://reviews.llvm.org/D151731?

[drprajap]

No, this was created by mistake when I wanted to update original review https://reviews.llvm.org/D151731, but I could not close this one. Is there any option to discard this review?

[kuhar]

You should be able to select 'Abandon' from the action menu on top of the new comment box.

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVCLOps.td

class SPIRV_CLBinaryOp<string mnemonic, int opcode, Type resultType,
   let hasVerifier = 0;
 }
 
 // Base class for OpenCL misc ops.
 class SPIRV_CLMiscOp<string mnemonic, int opcode, Type resultType,
                      list<Trait> traits = []> :
   SPIRV_CLOp<mnemonic, opcode, !listconcat([Pure], traits)> {
 
+  let results = (outs
+    SPIRV_ScalarOrVectorOf<resultType>:$result
+  );
+
   let hasVerifier = 0;
 }
 
 // Base class for OpenCL Binary arithmetic ops where operand types and
 // return type matches.
 class SPIRV_CLBinaryArithmeticOp<string mnemonic, int opcode, Type type,
                                  list<Trait> traits = []> :
   SPIRV_CLBinaryOp<mnemonic, opcode, type, type,
let description = [{
     printf returns 0 if it was executed successfully and -1 otherwise
 
     Result Type must be i32.
 
     format must be a pointer(constant) to i8.
 
     <!-- End of AutoGen section -->
 
-    ```
-    [TODO]
-    ```
-
     #### Example:
 
     ```mlir
-    # TODO - add rest of definitions
-    # %ptr = OpTypePointer UniformConstant %uchar
-    # %0 = OpInBoundsPtrAccessChain
-    # %1 = OpConstant
-    # %2 = OpConstant
-
-    %2 = spirv.CL.printf %0 %1 %2 : (!spirv.ptr<i8, UniformConstant>, (i32, i32)) -> i32
+    %0 = spirv.CL.printf %0 %1 %2 : (!spirv.ptr<i8, UniformConstant>, (i32, i32)) -> i32
 
     ```
   }];
 
   let arguments = (ins
     SPIRV_AnyPtr:$format,
     Variadic<SPIRV_Type>:$arguments
   );
 
-  let results = (outs
-    SPIRV_ScalarOrVectorOf<SPIRV_Integer>:$result
-  );
-
   let assemblyFormat = [{
   $format `,` $arguments  attr-dict `:`  `(` type($format) `,` `(` type($arguments) `)` `)` `->` type($result)
   }];
 
   let hasVerifier = 0;
 }
 #endif // MLIR_DIALECT_SPIRV_IR_CL_OPS

mlir/test/Dialect/SPIRV/IR/ocl-ops.mlir

func.func @rintvec(%arg0 : vector<3xf16>) -> () {
   return
 }
 
 // -----
 
 //===----------------------------------------------------------------------===//
 // spirv.CL.printf
 //===----------------------------------------------------------------------===//
-
-// spirv.GlobalVariable @global_var : !spirv.ptr<i8, UniformConstant>
-
-func.func @printf(%ptr : !spirv.ptr<i8, UniformConstant>, %arg1 : i32) -> () {
- // CHECK: spirv.CL.printf {{%.*}}, {{%.*}} : i32
-  %0 = spirv.CL.printf %ptr, %arg1 : i32
-  return
-}
-
-func.func @printf(%ptr : !spirv.ptr<i32, UniformConstant>, %arg1 : i32) -> () {
-  // expected-error @+1 {{op operand #0 must be pointr to constant i8}}
-  %0 = spirv.CL.printf %ptr, %arg1 : i32
-  return
+// CHECK-LABEL: func.func @printf(
+func.func @printf(%arg0 : !spirv.ptr<i8, UniformConstant>, %arg1 : i32, %arg2 : i32) -> i32 {
+  // CHECK: spirv.CL.printf {{%.*}}, {{%.*}}, {{%.*}} : (!spirv.ptr<i8, UniformConstant>, (i32, i32)) -> i32
+  %0 = spirv.CL.printf %arg0, %arg1, %arg2 : (!spirv.ptr<i8, UniformConstant>, (i32, i32)) -> i32
+  return %0 : i32
 }