This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] Update UnusedReturnValueCheck types
ClosedPublic

Authored by royjacobson on May 29 2023, 6:59 AM.

Details

Summary

Update the types for UnusedReturnValueCheck after D151383.

  1. Add std::errc, std:error_condition
  2. Remove absl::Status - it's marked as [[nodiscard]] anyway so it's redundant (and might create double warnings) to check it.

Diff Detail

Event Timeline

royjacobson created this revision.May 29 2023, 6:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
royjacobson requested review of this revision.May 29 2023, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 29 2023, 6:59 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
PiotrZSL accepted this revision.May 29 2023, 10:38 AM
This revision is now accepted and ready to land.May 29 2023, 10:38 AM

LGTM but update documentation for this check abseil::Status is listed there.

Update docs

This revision was landed with ongoing or failed builds.May 29 2023, 1:02 PM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added inline comments.May 29 2023, 1:51 PM
clang-tools-extra/docs/clang-tidy/checks/bugprone/unused-return-value.rst
53

should be break into 2 lines, 80 characters limit per line.