This is an archive of the discontinued LLVM Phabricator instance.

Differential D151609

[Driver] Remove unused class ForceSuccessCommand
ClosedPublic

Authored by kazu on May 26 2023, 9:45 PM.

Details

Reviewers
hans
thakis
Commits
rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand
Summary

The last use was removed by:

commit 6625680a581c5e29c53d9f58d864cc6cd3cd05f6
Author: Hans Wennborg <hans@chromium.org>
Date:   Tue Feb 2 14:10:26 2021 +0100

Diff Detail

Event Timeline

kazu created this revision.May 26 2023, 9:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 9:45 PM
kazu requested review of this revision.May 26 2023, 9:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2023, 9:45 PM
Herald added subscribers: cfe-commits, MaskRay. · View Herald Transcript
kazu added reviewers: hans, thakis.May 26 2023, 9:46 PM
Harbormaster completed remote builds in B234999: Diff 526241.May 27 2023, 4:01 PM
thakis accepted this revision.May 30 2023, 12:08 PM

lgtm, thanks!

(clicky: https://reviews.llvm.org/rG6625680a581c5e29c53d9f58d864cc6cd3cd05f6)

This revision is now accepted and ready to land.May 30 2023, 12:08 PM
Closed by commit rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand (authored by kazu). · Explain WhyMay 30 2023, 1:16 PM
This revision was automatically updated to reflect the committed changes.
kazu added a commit: rG692f3059fb95: [Driver] Remove unused class ForceSuccessCommand.

Revision Contents

PathSize
clang/
include/
clang/
Driver/
17 lines
lib/
Driver/
24 lines

Diff 526241

clang/include/clang/Driver/Job.h

Show First 20 Lines • Show All 252 Lines • ▼ Show 20 Lines void Print(llvm::raw_ostream &OS, const char *Terminator, bool Quote,
CrashReportInfo *CrashInfo = nullptr) const override; CrashReportInfo *CrashInfo = nullptr) const override;
int Execute(ArrayRef<std::optional<StringRef>> Redirects, std::string *ErrMsg, int Execute(ArrayRef<std::optional<StringRef>> Redirects, std::string *ErrMsg,
bool *ExecutionFailed) const override; bool *ExecutionFailed) const override;
void setEnvironment(llvm::ArrayRef<const char *> NewEnvironment) override; void setEnvironment(llvm::ArrayRef<const char *> NewEnvironment) override;
}; };
/// Like Command, but always pretends that the wrapped command succeeded.
class ForceSuccessCommand : public Command {
public:
ForceSuccessCommand(const Action &Source_, const Tool &Creator_,
ResponseFileSupport ResponseSupport,
const char *Executable_,
const llvm::opt::ArgStringList &Arguments_,
ArrayRef<InputInfo> Inputs,
ArrayRef<InputInfo> Outputs = std::nullopt);
void Print(llvm::raw_ostream &OS, const char *Terminator, bool Quote,
CrashReportInfo *CrashInfo = nullptr) const override;
int Execute(ArrayRef<std::optional<StringRef>> Redirects, std::string *ErrMsg,
bool *ExecutionFailed) const override;
};
/// JobList - A sequence of jobs to perform. /// JobList - A sequence of jobs to perform.
class JobList { class JobList {
public: public:
using list_type = SmallVector<std::unique_ptr<Command>, 4>; using list_type = SmallVector<std::unique_ptr<Command>, 4>;
using size_type = list_type::size_type; using size_type = list_type::size_type;
using iterator = llvm::pointee_iterator<list_type::iterator>; using iterator = llvm::pointee_iterator<list_type::iterator>;
using const_iterator = llvm::pointee_iterator<list_type::const_iterator>; using const_iterator = llvm::pointee_iterator<list_type::const_iterator>;
Show All 27 Lines

clang/lib/Driver/Job.cpp

Show First 20 Lines • Show All 443 Lines • ▼ Show 20 Lines
} }
void CC1Command::setEnvironment(llvm::ArrayRef<const char *> NewEnvironment) { void CC1Command::setEnvironment(llvm::ArrayRef<const char *> NewEnvironment) {
// We don't support set a new environment when calling into ExecuteCC1Tool() // We don't support set a new environment when calling into ExecuteCC1Tool()
llvm_unreachable( llvm_unreachable(
"The CC1Command doesn't support changing the environment vars!"); "The CC1Command doesn't support changing the environment vars!");
} }
ForceSuccessCommand::ForceSuccessCommand(
const Action &Source_, const Tool &Creator_,
ResponseFileSupport ResponseSupport, const char *Executable_,
const llvm::opt::ArgStringList &Arguments_, ArrayRef<InputInfo> Inputs,
ArrayRef<InputInfo> Outputs)
: Command(Source_, Creator_, ResponseSupport, Executable_, Arguments_,
Inputs, Outputs) {}
void ForceSuccessCommand::Print(raw_ostream &OS, const char *Terminator,
bool Quote, CrashReportInfo *CrashInfo) const {
Command::Print(OS, "", Quote, CrashInfo);
OS << " || (exit 0)" << Terminator;
}
int ForceSuccessCommand::Execute(ArrayRef<std::optional<StringRef>> Redirects,
std::string *ErrMsg,
bool *ExecutionFailed) const {
int Status = Command::Execute(Redirects, ErrMsg, ExecutionFailed);
(void)Status;
if (ExecutionFailed)
*ExecutionFailed = false;
return 0;
}
void JobList::Print(raw_ostream &OS, const char *Terminator, bool Quote, void JobList::Print(raw_ostream &OS, const char *Terminator, bool Quote,
CrashReportInfo *CrashInfo) const { CrashReportInfo *CrashInfo) const {
for (const auto &Job : *this) for (const auto &Job : *this)
Job.Print(OS, Terminator, Quote, CrashInfo); Job.Print(OS, Terminator, Quote, CrashInfo);
} }
void JobList::clear() { Jobs.clear(); } void JobList::clear() { Jobs.clear(); }