This is an archive of the discontinued LLVM Phabricator instance.

Differential D151339

[OpenCL] Add cl_ext_image_raw10_raw12 extension
ClosedPublic

Authored by svenvh on May 24 2023, 7:31 AM.

Details

Reviewers
Anastasia
Commits
rG5e8b44cc447e: [OpenCL] Add cl_ext_image_raw10_raw12 extension
Summary

Add the defines for the cl_ext_image_raw10_raw12 extension.

Draft extension specification is at https://github.com/KhronosGroup/OpenCL-Docs/pull/919

Diff Detail

Unit TestsFailed

TimeTest
230 msx64 debian > Flang.HLFIR::forall-index.fir
600 msx64 debian > Flang.Lower/HLFIR::forall.f90
620 msx64 debian > MLIR.Dialect/SparseTensor::pre_rewriting.mlir

Event Timeline

svenvh created this revision.May 24 2023, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 7:31 AM
Herald added subscribers: Naghasan, ldrumm, yaxunl. · View Herald Transcript
svenvh requested review of this revision.May 24 2023, 7:31 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 24 2023, 7:31 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B234203: Diff 525175.May 24 2023, 10:44 AM
Anastasia accepted this revision.Jun 4 2023, 12:07 PM

LGTM! Thanks

This revision is now accepted and ready to land.Jun 4 2023, 12:07 PM
This revision was landed with ongoing or failed builds.Jul 26 2023, 3:59 AM
Closed by commit rG5e8b44cc447e: [OpenCL] Add cl_ext_image_raw10_raw12 extension (authored by svenvh). · Explain Why
This revision was automatically updated to reflect the committed changes.
svenvh added a commit: rG5e8b44cc447e: [OpenCL] Add cl_ext_image_raw10_raw12 extension.

Revision Contents

PathSize
clang/
lib/
Headers/
5 lines
test/
Headers/
6 lines

Diff 525175

clang/lib/Headers/opencl-c-base.h

Show All 39 Lines
#define __opencl_c_ext_fp64_local_atomic_add 1 #define __opencl_c_ext_fp64_local_atomic_add 1
#define __opencl_c_ext_fp64_global_atomic_min_max 1 #define __opencl_c_ext_fp64_global_atomic_min_max 1
#define __opencl_c_ext_fp64_local_atomic_min_max 1 #define __opencl_c_ext_fp64_local_atomic_min_max 1
#endif #endif
#define __opencl_c_ext_fp32_global_atomic_add 1 #define __opencl_c_ext_fp32_global_atomic_add 1
#define __opencl_c_ext_fp32_local_atomic_add 1 #define __opencl_c_ext_fp32_local_atomic_add 1
#define __opencl_c_ext_fp32_global_atomic_min_max 1 #define __opencl_c_ext_fp32_global_atomic_min_max 1
#define __opencl_c_ext_fp32_local_atomic_min_max 1 #define __opencl_c_ext_fp32_local_atomic_min_max 1
#define __opencl_c_ext_image_raw10_raw12 1
#endif // defined(__SPIR__) || defined(__SPIRV__) #endif // defined(__SPIR__) || defined(__SPIRV__)
#endif // (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) #endif // (defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200)
// Define feature macros for OpenCL C 2.0 // Define feature macros for OpenCL C 2.0
#if (__OPENCL_CPP_VERSION__ == 100 || __OPENCL_C_VERSION__ == 200) #if (__OPENCL_CPP_VERSION__ == 100 || __OPENCL_C_VERSION__ == 200)
#define __opencl_c_pipes 1 #define __opencl_c_pipes 1
#define __opencl_c_generic_address_space 1 #define __opencl_c_generic_address_space 1
▲ Show 20 Lines • Show All 413 Lines • ▼ Show 20 Lines
#define CLK_SIGNED_INT16 0x10D8 #define CLK_SIGNED_INT16 0x10D8
#define CLK_SIGNED_INT32 0x10D9 #define CLK_SIGNED_INT32 0x10D9
#define CLK_UNSIGNED_INT8 0x10DA #define CLK_UNSIGNED_INT8 0x10DA
#define CLK_UNSIGNED_INT16 0x10DB #define CLK_UNSIGNED_INT16 0x10DB
#define CLK_UNSIGNED_INT32 0x10DC #define CLK_UNSIGNED_INT32 0x10DC
#define CLK_HALF_FLOAT 0x10DD #define CLK_HALF_FLOAT 0x10DD
#define CLK_FLOAT 0x10DE #define CLK_FLOAT 0x10DE
#define CLK_UNORM_INT24 0x10DF #define CLK_UNORM_INT24 0x10DF
#ifdef __opencl_c_ext_image_raw10_raw12
#define CLK_UNSIGNED_INT_RAW10_EXT 0x10E3
#define CLK_UNSIGNED_INT_RAW12_EXT 0x10E4
#endif // __opencl_c_ext_image_raw10_raw12
// Channel order, numbering must be aligned with cl_channel_order in cl.h // Channel order, numbering must be aligned with cl_channel_order in cl.h
// //
#define CLK_R 0x10B0 #define CLK_R 0x10B0
#define CLK_A 0x10B1 #define CLK_A 0x10B1
#define CLK_RG 0x10B2 #define CLK_RG 0x10B2
#define CLK_RA 0x10B3 #define CLK_RA 0x10B3
#define CLK_RGB 0x10B4 #define CLK_RGB 0x10B4
▲ Show 20 Lines • Show All 333 Lines • Show Last 20 Lines

clang/test/Headers/opencl-c-header.cl

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
#error "Incorrectly defined __opencl_c_ext_fp16_local_atomic_min_max" #error "Incorrectly defined __opencl_c_ext_fp16_local_atomic_min_max"
#endif #endif
#if __opencl_c_ext_fp32_local_atomic_min_max != 1 #if __opencl_c_ext_fp32_local_atomic_min_max != 1
#error "Incorrectly defined __opencl_c_ext_fp32_local_atomic_min_max" #error "Incorrectly defined __opencl_c_ext_fp32_local_atomic_min_max"
#endif #endif
#if __opencl_c_ext_fp64_local_atomic_min_max != 1 #if __opencl_c_ext_fp64_local_atomic_min_max != 1
#error "Incorrectly defined __opencl_c_ext_fp64_local_atomic_min_max" #error "Incorrectly defined __opencl_c_ext_fp64_local_atomic_min_max"
#endif #endif
#if __opencl_c_ext_image_raw10_raw12 != 1
#error "Incorrectly defined __opencl_c_ext_image_raw10_raw12"
#endif
#else #else
#ifdef cl_khr_subgroup_extended_types #ifdef cl_khr_subgroup_extended_types
#error "Incorrect cl_khr_subgroup_extended_types define" #error "Incorrect cl_khr_subgroup_extended_types define"
#endif #endif
#ifdef cl_khr_subgroup_non_uniform_vote #ifdef cl_khr_subgroup_non_uniform_vote
#error "Incorrect cl_khr_subgroup_non_uniform_vote define" #error "Incorrect cl_khr_subgroup_non_uniform_vote define"
▲ Show 20 Lines • Show All 68 Lines • ▼ Show 20 Lines
#error "Incorrectly __opencl_c_ext_fp16_local_atomic_min_max defined" #error "Incorrectly __opencl_c_ext_fp16_local_atomic_min_max defined"
#endif #endif
#ifdef __opencl_c_ext_fp32_local_atomic_min_max #ifdef __opencl_c_ext_fp32_local_atomic_min_max
#error "Incorrectly __opencl_c_ext_fp32_local_atomic_min_max defined" #error "Incorrectly __opencl_c_ext_fp32_local_atomic_min_max defined"
#endif #endif
#ifdef __opencl_c_ext_fp64_local_atomic_min_max #ifdef __opencl_c_ext_fp64_local_atomic_min_max
#error "Incorrectly __opencl_c_ext_fp64_local_atomic_min_max defined" #error "Incorrectly __opencl_c_ext_fp64_local_atomic_min_max defined"
#endif #endif
#ifdef __opencl_c_ext_image_raw10_raw12
#error "Incorrectly __opencl_c_ext_image_raw10_raw12 defined"
#endif
#endif //(defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200) #endif //(defined(__OPENCL_CPP_VERSION__) || __OPENCL_C_VERSION__ >= 200)
// OpenCL C features. // OpenCL C features.
#if (__OPENCL_CPP_VERSION__ == 202100 || __OPENCL_C_VERSION__ == 300) #if (__OPENCL_CPP_VERSION__ == 202100 || __OPENCL_C_VERSION__ == 300)
#if __opencl_c_atomic_scope_all_devices != 1 #if __opencl_c_atomic_scope_all_devices != 1
#error "Incorrectly defined feature macro __opencl_c_atomic_scope_all_devices" #error "Incorrectly defined feature macro __opencl_c_atomic_scope_all_devices"
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines