This is an archive of the discontinued LLVM Phabricator instance.

[test] Add C++ ext_vector_type tests
ClosedPublic

Authored by porglezomp on May 21 2023, 11:45 PM.

Details

Summary

Add initial tests for the behavior of ext_vector_type vectors for
vector vs scalar ops in C++. Their behavior doesn't agree with the behavior in
C and what the behavior seems like it should be, these are baseline tests before
implementing those changes.

Diff Detail

Event Timeline

porglezomp created this revision.May 21 2023, 11:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 11:45 PM
Herald added a subscriber: StephenFan. · View Herald Transcript
porglezomp requested review of this revision.May 21 2023, 11:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 21 2023, 11:45 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

See also: C versions of these test cases: D151061

I think the C versions behave correctly and that C++ should match that behavior.
Interested in feedback from anyone working with ext_vector_types.

Thank you for this coverage as well! Are there issues filed for the FIXME comments so we have a more prominent record of the problems?

LGTM modulo comment concerns.

clang/test/SemaCXX/vector.cpp
554

Same suggestion here as from the C patch.

Address review comments.
File GitHub issues and reference them with the FIXMEs.

fhahn accepted this revision.May 22 2023, 12:31 PM

LGTM, thanks!

This revision is now accepted and ready to land.May 22 2023, 12:31 PM
This revision was automatically updated to reflect the committed changes.