[lldb] Implement GetValueTypeFromAddressType

[augusto2112]

Summary

Value::ValueType is a superset of AddressType. Add a function to
convert an AddressType into a Value::ValueType.

[bulbazord]

Where do you plan on using this? Downstream I assume?

lldb/source/Core/Value.cpp

134–135

This switch is exhaustive, could you add an llvm_unreachable somewhere to indicate this? After the switch or something.

[augusto2112]

In D150826#4351518, @bulbazord wrote:

Where do you plan on using this? Downstream I assume?

Yes, I need this downstream, but seemed general enough to add upstream.

[augusto2112]

Add llvm_unreachable

[bulbazord]

LGTM

lldb/include/lldb/Core/Value.h

public:
 
   /// Convert this value's file address to a load address, if possible.
   void ConvertToLoadAddress(Module *module, Target *target);
 
   bool GetData(DataExtractor &data);
 
   void Clear();
 
+  static ValueType GetValueTypeFromAddressType(AddressType address_type);
+
 protected:
   Scalar m_value;
   CompilerType m_compiler_type;
   void *m_context = nullptr;
   ValueType m_value_type = ValueType::Scalar;
   ContextType m_context_type = ContextType::Invalid;
   DataBufferHeap m_data_buffer;
 };

lldb/source/Core/Value.cpp

AddressType Value::GetValueAddressType() const {
   case ValueType::FileAddress:
     return eAddressTypeFile;
   case ValueType::HostAddress:
     return eAddressTypeHost;
   }
   return eAddressTypeInvalid;
 }
 
+Value::ValueType Value::GetValueTypeFromAddressType(AddressType address_type) {
+  switch (address_type) {
+    case eAddressTypeFile:
+      return Value::ValueType::FileAddress;
+    case eAddressTypeLoad:
+      return Value::ValueType::LoadAddress;
+    case eAddressTypeHost:
+      return Value::ValueType::HostAddress;
+    case eAddressTypeInvalid:
+      return Value::ValueType::Invalid;
+  }
+  llvm_unreachable("Unexpected address type!");
+}
+
 RegisterInfo *Value::GetRegisterInfo() const {
   if (m_context_type == ContextType::RegisterInfo)
     return static_cast<RegisterInfo *>(m_context);
   return nullptr;
 }
 
 Type *Value::GetType() {
   if (m_context_type == ContextType::LLDBType)