Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

[zequanwu]

Summary

This fixes a nondeterminism on debug info when building on windows natively vs
cross building to windows. The file path was created at here that uses host path separator.

[rnk]

lgtm

[hans]

Nice! lgtm

clang/lib/AST/TypePrinter.cpp

1391

nit: If you want you could drop the "The following tries to" part to make this more concise.

[TWeaver]

Hello and good afternoon from the UK,

I believe this patch has caused failures on the following buildbot:

https://lab.llvm.org/buildbot/#/builders/216/builds/21493

are you able to take a look?

thanks,
Tom W

[zequanwu]

In D150817#4356305, @TWeaver wrote:

Hello and good afternoon from the UK,

I believe this patch has caused failures on the following buildbot:

https://lab.llvm.org/buildbot/#/builders/216/builds/21493

are you able to take a look?

thanks,
Tom W

Thanks for reporting. Hope this fix it: https://reviews.llvm.org/rGfe69bb64415ef6fe01ebbb1d1a801e85bd6bd879.

clang/lib/AST/TypePrinter.cpp

if (Policy.AnonymousTagLocations) {
       if (!HasKindDecoration)
         OS << " " << D->getKindName();
 
       PresumedLoc PLoc = D->getASTContext().getSourceManager().getPresumedLoc(
           D->getLocation());
       if (PLoc.isValid()) {
         OS << " at ";
         StringRef File = PLoc.getFilename();
+        llvm::SmallString<1024> WrittenFile(File);
         if (auto *Callbacks = Policy.Callbacks)
-          OS << Callbacks->remapPath(File);
-        else
-          OS << File;
-        OS << ':' << PLoc.getLine() << ':' << PLoc.getColumn();
+          WrittenFile = Callbacks->remapPath(File);
+        // Fix inconsistent path separator created by
+        // clang::DirectoryLookup::LookupFile when the file path is relative
+        // path.
+        llvm::sys::path::Style Style =
+            !llvm::sys::path::is_absolute(WrittenFile) && Policy.MSVCFormatting
+                ? llvm::sys::path::Style::windows_backslash
+                : llvm::sys::path::Style::native;
+        llvm::sys::path::native(WrittenFile, Style);
+        OS << WrittenFile << ':' << PLoc.getLine() << ':' << PLoc.getColumn();
       }
     }
 
     OS << (Policy.MSVCFormatting ? '\'' : ')');
   }
 
   // If this is a class template specialization, print the template
   // arguments.

clang/test/CodeGen/Inputs/debug-info-slash.h

+template <typename... T>
+void f1() {}
+void a() {
+  auto Lambda = [] {};
+  f1<decltype(Lambda)>();
+}

clang/test/CodeGen/Inputs/debug-info-slash.cpp

+#include "Inputs/debug-info-slash.h"
+int main() { a(); return 0; }

clang/test/CodeGen/debug-info-slash.test

+RUN: rm -rf %t-dir
+RUN: mkdir -p %t-dir/header/Inputs
+RUN: cp %S/Inputs/debug-info-slash.cpp %t-dir/
+RUN: cp %S/Inputs/debug-info-slash.h %t-dir/header/Inputs
+RUN: cd %t-dir
+RUN: %clang -target x86_64-pc-win32 -emit-llvm -S -g  %t-dir/debug-info-slash.cpp -Iheader -o - | FileCheck --check-prefix=WIN %s
+RUN: %clang -target x86_64-linux-gnu -emit-llvm -S -g  %t-dir/debug-info-slash.cpp -Iheader -o - | FileCheck --check-prefix=LINUX %s
+
+WIN:   lambda at header\\Inputs\\debug-info-slash.h
+LINUX: lambda at header/Inputs/debug-info-slash.h