This is an archive of the discontinued LLVM Phabricator instance.

Revert "[libc++] Implement P2505R5(Monadic operations for std::expected)."
ClosedPublic

Authored by yronglin on May 17 2023, 8:51 AM.

Details

Summary

This reverts commit ebc111b08bddca55d5f7e560a20bdb2c913d80cb.

Sorry, I forgot to append Phabricator reversion when land D140911, I try to revert this change and reland.

Diff Detail

Event Timeline

yronglin created this revision.May 17 2023, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 8:51 AM
Herald added a subscriber: arichardson. · View Herald Transcript
yronglin requested review of this revision.May 17 2023, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 17 2023, 8:51 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
yronglin edited the summary of this revision. (Show Details)May 17 2023, 8:53 AM
yronglin added reviewers: ldionne, philnik.
EricWF accepted this revision.May 17 2023, 9:48 AM
EricWF added a subscriber: EricWF.

If the bots are happy, then go ahead and revert+reland.
But if there are merge issues, then I think that forgetting the phab review number in the commit message is OK.

This revision is now accepted and ready to land.May 17 2023, 9:48 AM

If the bots are happy, then go ahead and revert+reland.
But if there are merge issues, then I think that forgetting the phab review number in the commit message is OK.

Thanks for your review and sorry for my mistake.

ldionne accepted this revision.May 17 2023, 9:52 AM
This revision was landed with ongoing or failed builds.May 17 2023, 9:57 AM
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/utilities/expected/expected.void/monadic/transform_error.pass.cpp