This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Remove the workaround of passing "-x assembler-with-cpp" manually
ClosedPublic

Authored by mstorsjo on May 16 2023, 11:37 AM.

Details

Summary

By building the assembly with language ASM now, this shouldn't be
needed.

Diff Detail

Event Timeline

mstorsjo created this revision.May 16 2023, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2023, 11:37 AM
mstorsjo requested review of this revision.May 16 2023, 11:37 AM
Herald added a project: Restricted Project. · View Herald Transcript

I guess this patch has to be deferred as the previous one was reverted.

The CMake version requirement patch has been landed and stably remained in main now for many weeks, so I believe this should be ready to proceed again.

tianshilei1992 accepted this revision.Jul 5 2023, 7:59 PM

Okay. Then let's go for it.

This revision is now accepted and ready to land.Jul 5 2023, 7:59 PM