This is an archive of the discontinued LLVM Phabricator instance.

[RegisterCoalescer] Remove DbgMergedVRegNums (NFC)
ClosedPublic

Authored by aheejin on May 15 2023, 1:14 PM.

Details

Summary

Not sure what this was originally intended for, but this seems to be
unused. It didn't seem to be used when it was first added in D64630
either.

Diff Detail

Event Timeline

aheejin created this revision.May 15 2023, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 1:14 PM
aheejin requested review of this revision.May 15 2023, 1:14 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 1:14 PM
jmorse accepted this revision.May 16 2023, 5:11 AM

/me squints -- hmmm, maybe this is why there were still false variable locations after register coalescing when I tried to fix them up, ouch.

The intention behind this was detecting when the repeated merging of virtual registers led to variable locations getting the wrong value -- which can happen transitively, hence there was a map for tracking which VRegs were now "in" other VRegs. The compile-time performance of this was bad, and it just didn't work properly in general, hence instr-ref recomputes SSA in full.

Seeing how nothing ever adds anything to DbgMergedVRegNums, it's clearly dead code and can be deleted.

This revision is now accepted and ready to land.May 16 2023, 5:11 AM
This revision was landed with ongoing or failed builds.May 18 2023, 4:03 PM
This revision was automatically updated to reflect the committed changes.