This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Fix QTimer::singleShot NewDeleteLeaks false positive
ClosedPublic

Authored by mkmvzlb on May 15 2023, 2:50 AM.

Details

Reviewers
NoQ
steakhal
Summary

Fixes #39713

Diff Detail

Event Timeline

mkmvzlb created this revision.May 15 2023, 2:50 AM
Herald added a project: Restricted Project. · View Herald Transcript
mkmvzlb requested review of this revision.May 15 2023, 2:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 15 2023, 2:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
steakhal accepted this revision.May 16 2023, 3:17 AM

Good job. Looks good to me.
This is pretty much analogous to D27717. The same reasoning applies.
Thanks for the patch. Should I commit this on your behalf?

This revision is now accepted and ready to land.May 16 2023, 3:17 AM

Thanks for the patch. Should I commit this on your behalf?

Thanks for reviewing and - in advance - for commit: --author "Michael Klein <m.klein@mvz-labor-lb.de>"

steakhal closed this revision.May 16 2023, 6:42 AM

And I managed to make a typo in the commit message :D
Closed by 3b6a368d763e812024ca6ba4024855603f693291