This is an archive of the discontinued LLVM Phabricator instance.

[Docs][llvm-exegesis] Specify platform support for different modes
ClosedPublic

Authored by aidengrossman on May 14 2023, 10:47 PM.

Details

Summary

llvm-exegesis has both a capture mode and an analysis mode that can be
used independently of each other. This patch makes it clear that
analysis mode will work on other platforms that LLVM supports in the
documentation which was unclear before.

Diff Detail

Event Timeline

aidengrossman created this revision.May 14 2023, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 10:47 PM
Herald added a subscriber: mstojanovic. · View Herald Transcript
aidengrossman requested review of this revision.May 14 2023, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 14 2023, 10:47 PM
aidengrossman added a subscriber: RKSimon.

Definitely an oversight on my part. Updates documentation on supported platforms (noting the platform support differences between the modes) based on a comment from @RKSimon in D149378.

courbet added inline comments.May 14 2023, 11:02 PM
llvm/docs/CommandGuide/llvm-exegesis.rst
37–40

This is called "benchmarking" elsewhere. Let's use that for consistency.

40

[nit] "on which LLVM is" ?

llvm/tools/llvm-exegesis/README.md
10–11

typo

12

on which

aidengrossman marked 4 inline comments as done.

Address reviewer feedback

courbet accepted this revision.May 14 2023, 11:21 PM
courbet added inline comments.
llvm/tools/llvm-exegesis/README.md
15–17

missing one

31

missing one

This revision is now accepted and ready to land.May 14 2023, 11:21 PM
This revision was automatically updated to reflect the committed changes.
aidengrossman marked 2 inline comments as done.