This is an archive of the discontinued LLVM Phabricator instance.

Differential D150190

[llvm-debuginfo-analyzer] Include linkage names while evaluating `--select`
ClosedPublic

Authored by n-omer on May 9 2023, 3:35 AM.

Details

Reviewers
CarlosAlbertoEnciso
Commits
rGc5ce3b136cfa: [llvm-debuginfo-analyzer] Include linkage names while evaluating `--select`
Summary

This patch allows mangled names to be passed to --select.

Diff Detail

Unit TestsFailed

TimeTest
60,060 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

n-omer created this revision.May 9 2023, 3:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 3:35 AM
Herald added subscribers: manas, ASDenysPetrov, dkrupp and 4 others. · View Herald Transcript
n-omer requested review of this revision.May 9 2023, 3:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 3:35 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B230834: Diff 520647.May 9 2023, 4:18 AM
gbedwell added a subscriber: gbedwell.May 12 2023, 3:18 AM

@CarlosAlbertoEnciso should review this ideally for approving, but I'm just nitpicking on a long line.

llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h
514

clang-format?

n-omer updated this revision to Diff 521612.May 12 2023, 5:22 AM

Address review comments.

n-omer marked an inline comment as done.May 12 2023, 5:23 AM
Harbormaster completed remote builds in B231571: Diff 521612.May 12 2023, 6:22 AM
CarlosAlbertoEnciso added a comment.May 15 2023, 2:08 AM

@n-omer as the selection feature is built into the logical view, can you add a test to /COFF/01-coff-select-logical-elements.test to cover the case of CodeView. Thanks.

n-omer updated this revision to Diff 522620.May 16 2023, 7:54 AM

Add codeview test.

Harbormaster completed remote builds in B232318: Diff 522620.May 16 2023, 9:22 AM
CarlosAlbertoEnciso accepted this revision.May 16 2023, 9:36 PM
This revision is now accepted and ready to land.May 16 2023, 9:36 PM
CarlosAlbertoEnciso added inline comments.May 16 2023, 9:42 PM
llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-select-logical-elements.test
72 ↗(On Diff #522620)

Can you add a simple comment describing what is printed. (Similar to the one in line 17). Thanks.

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test
75

Can you add a simple comment describing what is printed. (Similar to the one in line 17). Thanks.

n-omer updated this revision to Diff 523000.May 17 2023, 4:38 AM
n-omer marked 2 inline comments as done.

Address review comments.

Harbormaster completed remote builds in B232573: Diff 523000.May 17 2023, 5:14 AM
Closed by commit rGc5ce3b136cfa: [llvm-debuginfo-analyzer] Include linkage names while evaluating `--select` (authored by n-omer). · Explain WhyMay 17 2023, 6:12 AM
This revision was automatically updated to reflect the committed changes.
n-omer added a commit: rGc5ce3b136cfa: [llvm-debuginfo-analyzer] Include linkage names while evaluating `--select`.
n-omer added a comment.May 17 2023, 6:13 AM

Thanks @CarlosAlbertoEnciso.

Revision Contents

PathSize
llvm/
include/
llvm/
DebugInfo/
LogicalView/
Core/
2 lines
test/
tools/
llvm-debuginfo-analyzer/
DWARF/
20 lines

Diff 520647

llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h

Show First 20 Lines • Show All 505 Lines • ▼ Show 20 Linesclass LVPatterns final {
} }
void addElement(LVElement *Element); void addElement(LVElement *Element);
template <typename T, typename U> template <typename T, typename U>
void resolveGenericPatternMatch(T *Element, const U &Requests) { void resolveGenericPatternMatch(T *Element, const U &Requests) {
assert(Element && "Element must not be nullptr"); assert(Element && "Element must not be nullptr");
auto CheckPattern = [=]() -> bool { auto CheckPattern = [=]() -> bool {
return (Element->isNamed() && matchGenericPattern(Element->getName())) || return (Element->isNamed() && (matchGenericPattern(Element->getName()) || matchGenericPattern(Element->getLinkageName()))) ||
gbedwellUnsubmitted
Done
ReplyInline Actions

clang-format?

gbedwell: clang-format?
(Element->isTyped() && (Element->isTyped() &&
matchGenericPattern(Element->getTypeName())); matchGenericPattern(Element->getTypeName()));
}; };
auto CheckOffset = [=]() -> bool { auto CheckOffset = [=]() -> bool {
return matchOffsetPattern(Element->getOffset()); return matchOffsetPattern(Element->getOffset());
}; };
if ((options().getSelectGenericPattern() && CheckPattern()) || if ((options().getSelectGenericPattern() && CheckPattern()) ||
(options().getSelectOffsetPattern() && CheckOffset()) || (options().getSelectOffsetPattern() && CheckOffset()) ||
▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
; TWO-NEXT: [004] 5 {Variable} 'CONSTANT' -> 'const INTEGER' ; TWO-NEXT: [004] 5 {Variable} 'CONSTANT' -> 'const INTEGER'
; TWO-EMPTY: ; TWO-EMPTY:
; TWO-NEXT: Logical View: ; TWO-NEXT: Logical View:
; TWO-NEXT: [000] {File} 'test-dwarf-gcc.o' ; TWO-NEXT: [000] {File} 'test-dwarf-gcc.o'
; TWO-EMPTY: ; TWO-EMPTY:
; TWO-NEXT: [001] {CompileUnit} 'test.cpp' ; TWO-NEXT: [001] {CompileUnit} 'test.cpp'
; TWO-NEXT: [004] 4 {TypeAlias} 'INTEGER' -> 'int' ; TWO-NEXT: [004] 4 {TypeAlias} 'INTEGER' -> 'int'
; TWO-NEXT: [004] 5 {Variable} 'CONSTANT' -> 'const INTEGER' ; TWO-NEXT: [004] 5 {Variable} 'CONSTANT' -> 'const INTEGER'
; RUN: llvm-debuginfo-analyzer --attribute=level \
CarlosAlbertoEncisoUnsubmitted
Done
ReplyInline Actions

Can you add a simple comment describing what is printed. (Similar to the one in line 17). Thanks.

CarlosAlbertoEnciso: Can you add a simple comment describing what is printed. (Similar to the one in line 17).
; RUN: --select=_Z3fooPKijb \
; RUN: --report=list \
; RUN: --print=symbols,types \
; RUN: %p/Inputs/pr-57040-test-dwarf-clang.o \
; RUN: %p/Inputs/pr-57040-test-dwarf-gcc.o 2>&1 | \
; RUN: FileCheck --strict-whitespace -check-prefix=THREE %s
; THREE: Logical View:
; THREE-NEXT: [000] {File} 'pr-57040-test-dwarf-clang.o'
; THREE-EMPTY:
; THREE-NEXT: [001] {CompileUnit} 'test.cpp'
; THREE-NEXT: [002] 2 {Function} extern not_inlined 'foo' -> 'int'
; THREE-EMPTY:
; THREE: Logical View:
; THREE-NEXT: [000] {File} 'pr-57040-test-dwarf-gcc.o'
; THREE-EMPTY:
; THREE-NEXT: [001] {CompileUnit} 'test.cpp'
; THREE-NEXT: [002] 2 {Function} extern not_inlined 'foo' -> 'int'