[llvm-debuginfo-analyzer] Include linkage names while evaluating `--select`

[n-omer]

Summary

This patch allows mangled names to be passed to --select.

[gbedwell]

@CarlosAlbertoEnciso should review this ideally for approving, but I'm just nitpicking on a long line.

llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h

514–516

clang-format?

[n-omer]

Address review comments.

[CarlosAlbertoEnciso]

@n-omer as the selection feature is built into the logical view, can you add a test to /COFF/01-coff-select-logical-elements.test to cover the case of CodeView. Thanks.

[n-omer]

Add codeview test.

[CarlosAlbertoEnciso]

llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-select-logical-elements.test

72

Can you add a simple comment describing what is printed. (Similar to the one in line 17). Thanks.

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test

75

Can you add a simple comment describing what is printed. (Similar to the one in line 17). Thanks.

[n-omer]

Address review comments.

[n-omer]

Thanks @CarlosAlbertoEnciso.

llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h

class LVPatterns final {
   }
 
   void addElement(LVElement *Element);
 
   template <typename T, typename U>
   void resolveGenericPatternMatch(T *Element, const U &Requests) {
     assert(Element && "Element must not be nullptr");
     auto CheckPattern = [=]() -> bool {
-      return (Element->isNamed() && matchGenericPattern(Element->getName())) ||
+      return (Element->isNamed() &&
+              (matchGenericPattern(Element->getName()) ||
+               matchGenericPattern(Element->getLinkageName()))) ||
              (Element->isTyped() &&
               matchGenericPattern(Element->getTypeName()));
     };
     auto CheckOffset = [=]() -> bool {
       return matchOffsetPattern(Element->getOffset());
     };
     if ((options().getSelectGenericPattern() && CheckPattern()) ||
         (options().getSelectOffsetPattern() && CheckOffset()) ||

llvm/test/tools/llvm-debuginfo-analyzer/COFF/01-coff-select-logical-elements.test

 ; TWO-NEXT: [001]           {CompileUnit} 'test.cpp'
 ; TWO-NEXT: [003]           {TypeAlias} 'INTEGER' -> 'int'
 ; TWO-EMPTY:
 ; TWO-NEXT: Logical View:
 ; TWO-NEXT: [000]           {File} 'test-codeview-msvc.o'
 ; TWO-EMPTY:
 ; TWO-NEXT: [001]           {CompileUnit} 'test.cpp'
 ; TWO-NEXT: [004]           {TypeAlias} 'INTEGER' -> 'int'
+
+; Select logical elements by matching linkage names.
+; The following prints all symbols that
+; contain "?foo@@YAHPEBHI_N@Z" in their linkage names, using a tab layout
+; and given the number of matches.
+
+; RUN: llvm-debuginfo-analyzer --attribute=level \
+; RUN:                         --select=?foo@@YAHPEBHI_N@Z \
+; RUN:                         --report=list \
+; RUN:                         --print=symbols \
+; RUN:                         %p/Inputs/test-codeview-clang.o \
+; RUN:                         %p/Inputs/test-codeview-msvc.o 2>&1 | \
+; RUN: FileCheck --strict-whitespace -check-prefix=THREE %s
+
+; THREE:      Logical View:
+; THREE-NEXT: [000]           {File} 'test-codeview-clang.o'
+; THREE-EMPTY:
+; THREE-NEXT: [001]           {CompileUnit} 'test.cpp'
+; THREE-NEXT: [002]           {Function} extern not_inlined 'foo' -> 'int'
+; THREE-EMPTY:
+; THREE:      Logical View:
+; THREE-NEXT: [000]           {File} 'test-codeview-msvc.o'
+; THREE-EMPTY:
+; THREE-NEXT: [001]           {CompileUnit} 'test.cpp'
+; THREE-NEXT: [002]           {Function} extern not_inlined 'foo' -> 'int'

llvm/test/tools/llvm-debuginfo-analyzer/DWARF/01-dwarf-select-logical-elements.test

 ; TWO-NEXT: [004]     5     {Variable} 'CONSTANT' -> 'const INTEGER'
 ; TWO-EMPTY:
 ; TWO-NEXT: Logical View:
 ; TWO-NEXT: [000]           {File} 'test-dwarf-gcc.o'
 ; TWO-EMPTY:
 ; TWO-NEXT: [001]           {CompileUnit} 'test.cpp'
 ; TWO-NEXT: [004]     4     {TypeAlias} 'INTEGER' -> 'int'
 ; TWO-NEXT: [004]     5     {Variable} 'CONSTANT' -> 'const INTEGER'
+
+; Select logical elements based on linkage names.
+; The following prints all symbols that
+; contain "_Z3fooPKijb" in their linkage names, using a tab layout
+; and given the number of matches.
+
+; RUN: llvm-debuginfo-analyzer --attribute=level \
+; RUN:                         --select=_Z3fooPKijb \
+; RUN:                         --report=list \
+; RUN:                         --print=symbols \
+; RUN:                         %p/Inputs/pr-57040-test-dwarf-clang.o \
+; RUN:                         %p/Inputs/pr-57040-test-dwarf-gcc.o 2>&1 | \
+; RUN: FileCheck --strict-whitespace -check-prefix=THREE %s
+
+; THREE:      Logical View:
+; THREE-NEXT: [000]           {File} 'pr-57040-test-dwarf-clang.o'
+; THREE-EMPTY:
+; THREE-NEXT: [001]           {CompileUnit} 'test.cpp'
+; THREE-NEXT: [002]     2     {Function} extern not_inlined 'foo' -> 'int'
+; THREE-EMPTY:
+; THREE:      Logical View:
+; THREE-NEXT: [000]           {File} 'pr-57040-test-dwarf-gcc.o'
+; THREE-EMPTY:
+; THREE-NEXT: [001]           {CompileUnit} 'test.cpp'
+; THREE-NEXT: [002]     2     {Function} extern not_inlined 'foo' -> 'int'